[DevTools] Remove functionDetails from protocol.json

third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8InjectedScriptHost.h"
 
 #include "platform/inspector_protocol/String16.h"
 #include "platform/v8_inspector/InjectedScriptNative.h"
 #include "platform/v8_inspector/V8Compat.h"
 #include "platform/v8_inspector/V8DebuggerImpl.h"
+#include "platform/v8_inspector/V8InternalValueType.h"
 #include "platform/v8_inspector/V8StringUtil.h"
 #include "platform/v8_inspector/public/V8DebuggerClient.h"
 
 namespace blink {
 
 namespace {
 
 void setFunctionProperty(v8::Local<v8::Context> context, v8::Local<v8::Object> obj, const char* name, v8::FunctionCallback callback, v8::Local<v8::External> external)
 {
     v8::Local<v8::String> funcName = toV8StringInternalized(context->GetIsolate(), name);
@@ skipping 26 matching lines @@
     setFunctionProperty(context, injectedScriptHost, "isTypedArray", V8InjectedScriptHost::isTypedArrayCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "subtype", V8InjectedScriptHost::subtypeCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "getInternalProperties", V8InjectedScriptHost::getInternalPropertiesCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "suppressWarningsAndCallFunction", V8InjectedScriptHost::suppressWarningsAndCallFunctionCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "bind", V8InjectedScriptHost::bindCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "proxyTargetValue", V8InjectedScriptHost::proxyTargetValueCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "prototype", V8InjectedScriptHost::prototypeCallback, debuggerExternal);
     return injectedScriptHost;
 }
 
-v8::Local<v8::Private> V8InjectedScriptHost::internalEntryPrivate(v8::Isolate* isolate)
-{
-    return v8::Private::ForApi(isolate, toV8StringInternalized(isolate, "V8InjectedScriptHost#internalEntry"));
-}
-
-v8::Local<v8::Private> V8InjectedScriptHost::internalLocationPrivate(v8::Isolate* isolate)
-{
-    return v8::Private::ForApi(isolate, toV8StringInternalized(isolate, "V8InjectedScriptHost#internalLocation"));
-}
-
 void V8InjectedScriptHost::internalConstructorNameCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 1 || !info[0]->IsObject())
         return;
 
     v8::Local<v8::Object> object = info[0].As<v8::Object>();
     info.GetReturnValue().Set(object->GetConstructorName());
 }
 
 void V8InjectedScriptHost::formatAccessorsAsProperties(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ skipping 16 matching lines @@
     info.GetReturnValue().Set(info[0]->IsTypedArray());
 }
 
 void V8InjectedScriptHost::subtypeCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 1)
         return;
 
     v8::Isolate* isolate = info.GetIsolate();
     v8::Local<v8::Value> value = info[0];
+    if (value->IsObject()) {
+        V8InternalValueType internalType = internalValueType(isolate->GetCurrentContext(), v8::Local<v8::Object>::Cast(value));
+        switch (internalType) {
+        case V8InternalValueType::kEntry:
+            info.GetReturnValue().Set(toV8StringInternalized(isolate, "internal#entry"));
+            return;
+        case V8InternalValueType::kLocation:
+            info.GetReturnValue().Set(toV8StringInternalized(isolate, "internal#location"));
+            return;
+        case V8InternalValueType::kScope:
+            info.GetReturnValue().Set(toV8StringInternalized(isolate, "internal#scope"));
+            return;
+        case V8InternalValueType::kScopeList:
+            info.GetReturnValue().Set(toV8StringInternalized(isolate, "internal#scopeList"));
+            return;
+        case V8InternalValueType::kNotInternal:
+            break;
+        }
+    }
     if (value->IsArray() || value->IsTypedArray() || value->IsArgumentsObject()) {
         info.GetReturnValue().Set(toV8StringInternalized(isolate, "array"));
         return;
     }
     if (value->IsDate()) {
         info.GetReturnValue().Set(toV8StringInternalized(isolate, "date"));
         return;
     }
     if (value->IsRegExp()) {
         info.GetReturnValue().Set(toV8StringInternalized(isolate, "regexp"));
@@ skipping 16 matching lines @@
         return;
     }
     if (value->IsNativeError()) {
         info.GetReturnValue().Set(toV8StringInternalized(isolate, "error"));
         return;
     }
     if (value->IsProxy()) {
         info.GetReturnValue().Set(toV8StringInternalized(isolate, "proxy"));
         return;
     }
-    if (value->IsObject()) {
-        v8::Local<v8::Object> obj = value.As<v8::Object>();
-        if (obj->HasPrivate(isolate->GetCurrentContext(), internalEntryPrivate(isolate)).FromMaybe(false)) {
-            info.GetReturnValue().Set(toV8StringInternalized(isolate, "internal#entry"));
-            return;
-        }
-        if (obj->HasPrivate(isolate->GetCurrentContext(), internalLocationPrivate(isolate)).FromMaybe(false)) {
-            info.GetReturnValue().Set(toV8StringInternalized(isolate, "internal#location"));
-            return;
-        }
-    }
     String16 subtype = unwrapDebugger(info)->client()->valueSubtype(value);
     if (!subtype.isEmpty()) {
         info.GetReturnValue().Set(toV8String(isolate, subtype));
         return;
     }
 }
 
 void V8InjectedScriptHost::getInternalPropertiesCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 1)
@@ skipping 71 matching lines @@
     info.GetReturnValue().Set(target);
 }
 
 void V8InjectedScriptHost::prototypeCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     DCHECK(info.Length() > 0 && info[0]->IsObject());
     info.GetReturnValue().Set(info[0].As<v8::Object>()->GetPrototype());
 }
 
 } // namespace blink