Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

Issue 2122423002: [DevTools] Remove functionDetails from protocol.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-generator-details-from-protocol
Patch Set: addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 { 68 {
69 if (internalProperties) { 69 if (internalProperties) {
70 for (var i = 0; i < internalProperties.length; i++) { 70 for (var i = 0; i < internalProperties.length; i++) {
71 if (internalProperties[i].name === "[[TargetFunction]]") { 71 if (internalProperties[i].name === "[[TargetFunction]]") {
72 funcObject = internalProperties[i].value; 72 funcObject = internalProperties[i].value;
73 break; 73 break;
74 } 74 }
75 } 75 }
76 } 76 }
77 WebInspector.ObjectPropertiesSection.formatObjectAsFunction(funcObje ct, popoverValueElement, true); 77 WebInspector.ObjectPropertiesSection.formatObjectAsFunction(funcObje ct, popoverValueElement, true);
78 funcObject.functionDetails(didGetFunctionDetails.bind(this, popoverC ontentElement, anchorElement)); 78 funcObject.debuggerModel().functionDetailsPromise(funcObject).then(d idGetFunctionDetails.bind(this, popoverContentElement, anchorElement));
79 } 79 }
80 80
81 /** 81 /**
82 * @param {!Element} popoverContentElement 82 * @param {!Element} popoverContentElement
83 * @param {!Element} anchorElement 83 * @param {!Element} anchorElement
84 * @param {?WebInspector.DebuggerModel.FunctionDetails} response 84 * @param {?WebInspector.DebuggerModel.FunctionDetails} response
85 * @this {WebInspector.ObjectPopoverHelper} 85 * @this {WebInspector.ObjectPopoverHelper}
86 */ 86 */
87 function didGetFunctionDetails(popoverContentElement, anchorElement, res ponse) 87 function didGetFunctionDetails(popoverContentElement, anchorElement, res ponse)
88 { 88 {
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 */ 195 */
196 _lazyLinkifier: function() 196 _lazyLinkifier: function()
197 { 197 {
198 if (!this._linkifier) 198 if (!this._linkifier)
199 this._linkifier = new WebInspector.Linkifier(); 199 this._linkifier = new WebInspector.Linkifier();
200 return this._linkifier; 200 return this._linkifier;
201 }, 201 },
202 202
203 __proto__: WebInspector.PopoverHelper.prototype 203 __proto__: WebInspector.PopoverHelper.prototype
204 } 204 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698