[DevTools] Remove functionDetails from protocol.json

third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 181 matching lines @@
  * @const
  */
 InjectedScript.primitiveTypes = {
     "undefined": true,
     "boolean": true,
     "number": true,
     "string": true,
     __proto__: null
 }
 
+/**
+ * @type {!Map<string, string>}
+ * @const
+ */
+InjectedScript.closureTypes = new Map([
+    ["local", "Local"],
+    ["closure", "Closure"],
+    ["catch", "Catch"],
+    ["block", "Block"],
+    ["script", "Script"],
+    ["with", "With Block"],
+    ["global", "Global"]
+]);
+
 InjectedScript.prototype = {
     /**
      * @param {*} object
      * @return {boolean}
      */
     isPrimitiveValue: function(object)
     {
         // FIXME(33716): typeof document.all is always 'undefined'.
         return InjectedScript.primitiveTypes[typeof object] && !this._isHTMLAllCollection(object);
     },
@@ skipping 128 matching lines @@
     /**
      * @param {!Object} object
      * @param {string} objectGroupName
      * @param {boolean} ownProperties
      * @param {boolean} accessorPropertiesOnly
      * @param {boolean} generatePreview
      * @return {!Array<!RuntimeAgent.PropertyDescriptor>|boolean}
      */
     getProperties: function(object, objectGroupName, ownProperties, accessorPropertiesOnly, generatePreview)
     {
+        var subtype = this._subtype(object);
+        if (subtype === "internal#scope")
+            object = object.object;

[dgozman, 2016/07/07 19:59:23]

This needs a justification.

[kozy, 2016/07/07 22:59:08]

Added comment.

+
         var descriptors = [];
         var iter = this._propertyDescriptors(object, ownProperties, accessorPropertiesOnly, undefined);
         // Go over properties, wrap object values.
         for (var descriptor of iter) {
             if ("get" in descriptor)
                 descriptor.get = this._wrapObject(descriptor.get, objectGroupName);
             if ("set" in descriptor)
                 descriptor.set = this._wrapObject(descriptor.set, objectGroupName);
             if ("value" in descriptor)
                 descriptor.value = this._wrapObject(descriptor.value, objectGroupName, false, generatePreview);
@@ skipping 283 matching lines @@
             } catch(e) {
             }
         }
 
         if (subtype === "internal#entry") {
             if ("key" in obj)
                 return "{" + this._describeIncludingPrimitives(obj.key) + " => " + this._describeIncludingPrimitives(obj.value) + "}";
             return this._describeIncludingPrimitives(obj.value);
         }
 
+        if (subtype === "internal#scopes")

[dgozman, 2016/07/07 19:59:23]

scopeList

[kozy, 2016/07/07 22:59:08]

Done.

+            return "Scopes[" + obj.length + "]";
+
+        if (subtype === "internal#scope")
+            return (InjectedScript.closureTypes.get(obj.type) || "Unknown") + (obj.name ? "(" + obj.name + ")" : "");

[dgozman, 2016/07/07 19:59:23]

maybe space before "(" ?

[kozy, 2016/07/07 22:59:08]

Done.

+
         return className;
     },
 
     /**
      * @param {*} value
      * @return {string}
      */
     _describeIncludingPrimitives: function(value)
     {
         if (typeof value === "string")
@@ skipping 382 matching lines @@
             return string.substr(0, leftHalf) + "\u2026" + string.substr(string.length - rightHalf, rightHalf);
         }
         return string.substr(0, maxLength) + "\u2026";
     },
 
     __proto__: null
 }
 
 return injectedScript;
 })