Chromium Code Reviews Chromium Code Reviews
Issue 2122423002:
[DevTools] Remove functionDetails from protocol.json (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@remove-generator-details-from-protocol| OLD | NEW |
|---|---|
| 1 Tests that Debugger.getFunctionDetails command returns correct location. Bug 718 08 | 1 Tests that Debugger.getFunctionDetails command returns correct location. Bug 718 08 |
| 2 | 2 |
| 3 | 3 |
| 4 Running: testGetFirstLineFunctionDetails | 4 Running: testGetFirstLineFunctionDetails |
| 5 firstLineFunction type = function | 5 firstLineFunction type = function |
| 6 Function details: | 6 Function details: |
| 7 lineNumber: 5 | 7 lineNumber: 5 |
| 8 columnNumber: 36 | 8 columnNumber: 36 |
| 9 scriptId is valid: true | 9 scriptId is valid: true |
| 10 functionName: firstLineFunction | 10 functionName: firstLineFunction |
| 11 isGenerator: false | 11 isGenerator: false |
| 12 scopeChain #0: global; <global object properties omitted> | 12 scopeChain #0: Global; <global object properties omitted> |
| 13 | 13 |
| 14 Running: testGetNonFirstLineFunctionDetails | 14 Running: testGetNonFirstLineFunctionDetails |
| 15 notFirstLineFunction type = function | 15 notFirstLineFunction type = function |
| 16 Function details: | 16 Function details: |
| 17 lineNumber: 10 | 17 lineNumber: 10 |
| 18 columnNumber: 32 | 18 columnNumber: 32 |
| 19 scriptId is valid: true | 19 scriptId is valid: true |
| 20 functionName: notFirstLineFunction | 20 functionName: notFirstLineFunction |
| 21 isGenerator: false | 21 isGenerator: false |
| 22 scopeChain #0: global; <global object properties omitted> | 22 scopeChain #0: Global; <global object properties omitted> |
| 23 | 23 |
| 24 Running: testGetDetailsOfFunctionWithInferredName | 24 Running: testGetDetailsOfFunctionWithInferredName |
| 25 obj.m type = function | 25 obj.m type = function |
| 26 Function details: | 26 Function details: |
| 27 lineNumber: 16 | 27 lineNumber: 16 |
| 28 columnNumber: 15 | 28 columnNumber: 15 |
| 29 scriptId is valid: true | 29 scriptId is valid: true |
| 30 functionName: m | 30 functionName: m |
| 31 isGenerator: false | 31 isGenerator: false |
| 32 scopeChain #0: global; <global object properties omitted> | 32 scopeChain #0: Global; <global object properties omitted> |
| 33 | 33 |
| 34 Running: testGetDetailsOfFunctionWithDisplayName | 34 Running: testGetDetailsOfFunctionWithDisplayName |
| 35 functionWithDisplayName type = function | 35 functionWithDisplayName type = function |
| 36 Function details: | 36 Function details: |
| 37 lineNumber: 19 | 37 lineNumber: 19 |
| 38 columnNumber: 32 | 38 columnNumber: 32 |
| 39 scriptId is valid: true | 39 scriptId is valid: true |
| 40 functionName: user-friendly name | 40 functionName: user-friendly name |
| 41 isGenerator: false | 41 isGenerator: false |
| 42 scopeChain #0: global; <global object properties omitted> | 42 scopeChain #0: Global; <global object properties omitted> |
| 43 | 43 |
| 44 Running: testGetDetailsOfFunctionWithDisplayNameGetter | 44 Running: testGetDetailsOfFunctionWithDisplayNameGetter |
| 45 functionWithDisplayNameGetter type = function | 45 functionWithDisplayNameGetter type = function |
| 46 Function details: | 46 Function details: |
| 47 lineNumber: 22 | 47 lineNumber: 22 |
| 48 columnNumber: 38 | 48 columnNumber: 38 |
| 49 scriptId is valid: true | 49 scriptId is valid: true |
| 50 functionName: functionWithDisplayNameGetter | 50 functionName: functionWithDisplayNameGetter |
| 51 isGenerator: false | 51 isGenerator: false |
| 52 scopeChain #0: global; <global object properties omitted> | 52 scopeChain #0: Global; <global object properties omitted> |
| 53 | 53 |
| 54 Running: testSmallClosure | 54 Running: testSmallClosure |
| 55 smallClosure type = function | 55 smallClosure type = function |
| 56 Function details: | 56 Function details: |
| 57 lineNumber: 25 | 57 lineNumber: 25 |
| 58 columnNumber: 49 | 58 columnNumber: 49 |
| 59 scriptId is valid: true | 59 scriptId is valid: true |
| 60 functionName: | 60 functionName: |
| 61 isGenerator: false | 61 isGenerator: false |
| 62 scopeChain #0: closure; p: "Capybara" | 62 scopeChain #0: Closure; p: "Capybara" |
| 63 scopeChain #1: global; <global object properties omitted> | 63 scopeChain #1: Global; <global object properties omitted> |
| 64 | 64 |
| 65 Running: testBigClosure | 65 Running: testBigClosure |
| 66 bigClosure type = function | 66 bigClosure type = function |
| 67 Function details: | 67 Function details: |
| 68 lineNumber: 38 | 68 lineNumber: 38 |
| 69 columnNumber: 27 | 69 columnNumber: 27 |
| 70 scriptId is valid: true | 70 scriptId is valid: true |
| 71 functionName: | 71 functionName: |
| 72 isGenerator: false | 72 isGenerator: false |
| 73 scopeChain #0: catch; ex: <no string representation> | 73 scopeChain #0: Catch; ex: <no string representation> |
| 74 scopeChain #1: with; __proto__: <no string representation>,e: 7,f: 5,u: <no valu e>,v: <no value> | 74 scopeChain #1: With Block; __proto__: <no string representation>,e: 7,f: 5,u: <n o value>,v: <no value> |
|
dgozman
2016/07/07 19:59:23
Why did all these change? Is it important?
kozy
2016/07/07 22:59:07
Before we report scope with internal type that sta
| |
| 75 scopeChain #2: closure; p: <no string representation> | 75 scopeChain #2: Closure; p: <no string representation> |
| 76 scopeChain #3: global; <global object properties omitted> | 76 scopeChain #3: Global; <global object properties omitted> |
| 77 | 77 |
| OLD | NEW |
