Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2122423002: [DevTools] Remove functionDetails from protocol.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-generator-details-from-protocol
Patch Set: a Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1020 matching lines...) Expand 10 before | Expand all | Expand 10 after
1031 } 1031 }
1032 WebInspector.console.error(message); 1032 WebInspector.console.error(message);
1033 } 1033 }
1034 }, 1034 },
1035 1035
1036 /** 1036 /**
1037 * @param {!WebInspector.RemoteObject} remoteObject 1037 * @param {!WebInspector.RemoteObject} remoteObject
1038 */ 1038 */
1039 _showFunctionDefinition: function(remoteObject) 1039 _showFunctionDefinition: function(remoteObject)
1040 { 1040 {
1041 remoteObject.debuggerModel().functionDetails(remoteObject, this._didGetF unctionDetails.bind(this)); 1041 remoteObject.debuggerModel().functionDetailsPromise(remoteObject).then(t his._didGetFunctionDetails.bind(this));
1042 }, 1042 },
1043 1043
1044 /** 1044 /**
1045 * @param {?{location: ?WebInspector.DebuggerModel.Location}} response 1045 * @param {?{location: ?WebInspector.DebuggerModel.Location}} response
1046 */ 1046 */
1047 _didGetFunctionDetails: function(response) 1047 _didGetFunctionDetails: function(response)
1048 { 1048 {
1049 if (!response || !response.location) 1049 if (!response || !response.location)
1050 return; 1050 return;
1051 1051
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
1470 __proto__: WebInspector.VBox.prototype 1470 __proto__: WebInspector.VBox.prototype
1471 } 1471 }
1472 1472
1473 /** 1473 /**
1474 * @return {boolean} 1474 * @return {boolean}
1475 */ 1475 */
1476 WebInspector.SourcesPanel.WrapperView.isShowing = function() 1476 WebInspector.SourcesPanel.WrapperView.isShowing = function()
1477 { 1477 {
1478 return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.Sou rcesPanel.WrapperView._instance.isShowing(); 1478 return !!WebInspector.SourcesPanel.WrapperView._instance && WebInspector.Sou rcesPanel.WrapperView._instance.isShowing();
1479 } 1479 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698