Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2122363002: DBC: Implement TestCids instruction. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: Implement TestCids instruction. Separate out instructions that won't be implemented. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/0737ee08bf9bb40e54594828351965b506bd8035

Patch Set 1 #

Total comments: 12

Patch Set 2 : sync, review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -6 lines) Patch
M runtime/vm/assembler_dbc.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/assembler_dbc_test.cc View 1 1 chunk +85 lines, -0 lines 0 comments Download
M runtime/vm/constants_dbc.h View 1 3 chunks +9 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 1 8 chunks +82 lines, -5 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 5 months ago (2016-07-07 00:36:15 UTC) #2
Vyacheslav Egorov (Google)
lgtm https://chromiumcodereview.appspot.com/2122363002/diff/1/runtime/vm/constants_dbc.h File runtime/vm/constants_dbc.h (right): https://chromiumcodereview.appspot.com/2122363002/diff/1/runtime/vm/constants_dbc.h#newcode382 runtime/vm/constants_dbc.h:382: // the class id of FP[rA] matches, jump ...
4 years, 5 months ago (2016-07-07 17:08:28 UTC) #3
rmacnak
https://chromiumcodereview.appspot.com/2122363002/diff/1/runtime/vm/constants_dbc.h File runtime/vm/constants_dbc.h (right): https://chromiumcodereview.appspot.com/2122363002/diff/1/runtime/vm/constants_dbc.h#newcode382 runtime/vm/constants_dbc.h:382: // the class id of FP[rA] matches, jump to ...
4 years, 5 months ago (2016-07-08 00:54:21 UTC) #4
rmacnak
4 years, 5 months ago (2016-07-08 00:57:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0737ee08bf9bb40e54594828351965b506bd8035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698