Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js

Issue 2122353002: [DevTools] Make resource tree model optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
index 3bde9307c1adbb04e46b058c61eacf5e617594f7..e0fec5d25c83be975452372565976f560e104a86 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
@@ -57,7 +57,9 @@ WebInspector.WorkerManager.prototype = {
this._enabled = true;
this.target().workerAgent().enable();
- this.target().resourceTreeModel.addEventListener(WebInspector.TargetManager.Events.MainFrameNavigated, this._mainFrameNavigated, this);
+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this.target());
+ if (resourceTreeModel)
+ resourceTreeModel.addEventListener(WebInspector.TargetManager.Events.MainFrameNavigated, this._mainFrameNavigated, this);
},
disable: function()
@@ -67,7 +69,9 @@ WebInspector.WorkerManager.prototype = {
this._enabled = false;
this._reset();
this.target().workerAgent().disable();
- this.target().resourceTreeModel.removeEventListener(WebInspector.TargetManager.Events.MainFrameNavigated, this._mainFrameNavigated, this);
+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this.target());
+ if (resourceTreeModel)
+ resourceTreeModel.removeEventListener(WebInspector.TargetManager.Events.MainFrameNavigated, this._mainFrameNavigated, this);
dgozman 2016/07/14 16:29:29 This is a very strange dependency. I think it shou
eostroukhov-old 2016/07/20 23:46:16 Switched to listening to TargetManager instead.
},
dispose: function()

Powered by Google App Engine
This is Rietveld 408576698