Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

Issue 2122353002: [DevTools] Make resource tree model optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
index 74c4c81cb0a376027199fd532f67d6ee649b4668..074adac819fd09c5bb58381dde5f1ddbc9e601f1 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
@@ -53,8 +53,11 @@ WebInspector.ServiceWorkersView.prototype = {
this._manager.addEventListener(WebInspector.ServiceWorkerManager.Events.RegistrationUpdated, this._registrationUpdated, this);
this._manager.addEventListener(WebInspector.ServiceWorkerManager.Events.RegistrationDeleted, this._registrationDeleted, this);
this._manager.addEventListener(WebInspector.ServiceWorkerManager.Events.RegistrationErrorAdded, this._registrationErrorAdded, this);
- this._target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.SecurityOriginAdded, this._updateSectionVisibility, this);
- this._target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.SecurityOriginRemoved, this._updateSectionVisibility, this);
+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this._target);
dgozman 2016/07/14 16:29:28 ditto
eostroukhov-old 2016/07/20 23:46:15 Done.
+ if (resourceTreeModel) {
+ resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.SecurityOriginAdded, this._updateSectionVisibility, this);
+ resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.SecurityOriginRemoved, this._updateSectionVisibility, this);
+ }
},
/**
@@ -70,7 +73,8 @@ WebInspector.ServiceWorkersView.prototype = {
_updateSectionVisibility: function()
{
- var securityOrigins = new Set(this._target.resourceTreeModel.securityOrigins());
+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this._target);
+ var securityOrigins = new Set(resourceTreeModel ? resourceTreeModel.securityOrigins() : []);
for (var section of this._sections.values()) {
var visible = this._showAllCheckbox.checked() || securityOrigins.has(section._registration.securityOrigin);
section._section.element.classList.toggle("hidden", !visible);

Powered by Google App Engine
This is Rietveld 408576698