third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js - Issue 2122353002: [DevTools] Make resource tree model optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

Issue 2122353002: [DevTools] Make resource tree model optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js ('K') | « third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js » ('j') | third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

index a458ab19f198bd24d4a974c94461682a68729bf3..3140b273f68b427223d46dbdec59119051c61541 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

@@ -70,7 +70,9 @@ WebInspector.AppManifestView.prototype = {

_updateManifest: function()

{

- this._target.resourceTreeModel.fetchAppManifest(this._renderManifest.bind(this));

+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this._target);

dgozman 2016/07/14 16:29:28 I'd rather set this._resourceTreeModel in targetAd

eostroukhov-old 2016/07/20 23:46:15 Done.

+ if (resourceTreeModel)

+ resourceTreeModel.fetchAppManifest(this._renderManifest.bind(this));

/**