Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js

Issue 2122353002: [DevTools] Make resource tree model optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js b/third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js
index 97de0586200754321ab7fe0cf5284e3bcb537bf1..7260c9c08b13eca607dab2ff556058de85032e08 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js
@@ -36,7 +36,8 @@ WebInspector.resourceForURL = function(url)
{
var targets = WebInspector.targetManager.targets();
dgozman 2016/07/14 16:29:28 Pass browser capability? This way you can be sure
eostroukhov-old 2016/07/20 23:46:15 Done.
for (var i = 0; i < targets.length; ++i) {
- var resource = targets[i].resourceTreeModel.resourceForURL(url);
+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(targets[i]);
+ var resource = resourceTreeModel && resourceTreeModel.resourceForURL(url);
if (resource)
return resource;
}
@@ -49,8 +50,11 @@ WebInspector.resourceForURL = function(url)
WebInspector.forAllResources = function(callback)
{
var targets = WebInspector.targetManager.targets();
dgozman 2016/07/14 16:29:28 ditto
eostroukhov-old 2016/07/20 23:46:15 Done.
- for (var i = 0; i < targets.length; ++i)
- targets[i].resourceTreeModel.forAllResources(callback);
+ for (var i = 0; i < targets.length; ++i) {
+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(targets[i]);
+ if (resourceTreeModel)
+ resourceTreeModel.forAllResources(callback);
+ }
}
/**

Powered by Google App Engine
This is Rietveld 408576698