third_party/WebKit/Source/devtools/front_end/audits/AuditController.js - Issue 2122353002: [DevTools] Make resource tree model optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

Issue 2122353002: [DevTools] Make resource tree model optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js ('K') | « third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js ('k') | third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

index be7afd40c44cab1e3f2b44081d9f31e58dd4179f..1bf3501dea3464d66127a85d2ad11fc6b9741d7a 100644

--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

@@ -61,7 +61,8 @@ WebInspector.AuditController.prototype = {

}

var results = [];

- var mainResourceURL = target.resourceTreeModel.inspectedPageURL();

+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(target);

+ var mainResourceURL = resourceTreeModel ? resourceTreeModel.inspectedPageURL() : "main";

pfeldman 2016/07/13 23:55:57 s/"main"/""/

eostroukhov-old 2016/07/20 23:46:14 Done.

var categoriesDone = 0;

function categoryDoneCallback()