third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js - Issue 2122353002: [DevTools] Make resource tree model optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

Issue 2122353002: [DevTools] Make resource tree model optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js ('k') | third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js b/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

index 2347ad521bfae62a6e034df302ef24ae7c486265..4f9e5fac6378a60b1fbb3943094af577f7bf932d 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

@@ -159,11 +159,16 @@ WebInspector.DOMPresentationUtils.linkifyDeferredNodeReference = function(deferr

WebInspector.DOMPresentationUtils.buildImagePreviewContents = function(target, originalImageURL, showDimensions, userCallback, precomputedFeatures)

{

- var resource = target.resourceTreeModel.resourceForURL(originalImageURL);

+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(target);

+ if (!resourceTreeModel) {

+ userCallback();

+ return;

+ }

+ var resource = resourceTreeModel.resourceForURL(originalImageURL);

var imageURL = originalImageURL;

if (!isImageResource(resource) && precomputedFeatures && precomputedFeatures.currentSrc) {

imageURL = precomputedFeatures.currentSrc;

- resource = target.resourceTreeModel.resourceForURL(imageURL);

+ resource = resourceTreeModel.resourceForURL(imageURL);

}

if (!isImageResource(resource)) {

userCallback();