third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js - Issue 2122353002: [DevTools] Make resource tree model optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js

Issue 2122353002: [DevTools] Make resource tree model optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js

index 2313c2ec23de4c85dceb11d65ab7b1af21cdedd6..ce86248da89a095ff5dfea0b3c634bb8b6902ef4 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js

@@ -57,7 +57,9 @@ WebInspector.WorkerManager.prototype = {

this._enabled = true;

this.target().workerAgent().enable();

- this.target().resourceTreeModel.addEventListener(WebInspector.TargetManager.Events.MainFrameNavigated, this._mainFrameNavigated, this);

+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this.target());

+ if (resourceTreeModel)

+ resourceTreeModel.addEventListener(WebInspector.TargetManager.Events.MainFrameNavigated, this._mainFrameNavigated, this);

disable: function()

@@ -67,7 +69,9 @@ WebInspector.WorkerManager.prototype = {

this._enabled = false;

this._reset();

this.target().workerAgent().disable();

- this.target().resourceTreeModel.removeEventListener(WebInspector.TargetManager.Events.MainFrameNavigated, this._mainFrameNavigated, this);

+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this.target());

+ if (resourceTreeModel)

+ resourceTreeModel.removeEventListener(WebInspector.TargetManager.Events.MainFrameNavigated, this._mainFrameNavigated, this);

dispose: function()