[DevTools] Make resource tree model optional

third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.SDKModel}
  * @param {!WebInspector.Target} target
  * @param {!WebInspector.NetworkManager} networkManager
+ * @param {?WebInspector.ResourceTreeModel} resourceTreeModel
  */
-WebInspector.NetworkLog = function(target, networkManager)
+WebInspector.NetworkLog = function(target, networkManager, resourceTreeModel)
 {
     WebInspector.SDKModel.call(this, WebInspector.NetworkLog, target);
 
     this._requests = [];
     this._requestForId = {};
     networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestStarted, this._onRequestStarted, this);
-    target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._onMainFrameNavigated, this);
-    target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.Load, this._onLoad, this);
-    target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.DOMContentLoaded, this._onDOMContentLoaded, this);
+    if (resourceTreeModel) {

[dgozman, 2016/07/14 16:29:29]

This dependency looks strange. Can we eliminate it?

[eostroukhov-old, 2016/07/20 23:46:15]

NetworkLog is currently considered a browser-only model as it extensively refers
to page loads and such.

+        resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._onMainFrameNavigated, this);
+        resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.Load, this._onLoad, this);
+        resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.DOMContentLoaded, this._onDOMContentLoaded, this);
+    }
 }
 
 /**
  * @param {!WebInspector.Target} target
  * @return {?WebInspector.NetworkLog}
  */
 WebInspector.NetworkLog.fromTarget = function(target)
 {
     return /** @type {?WebInspector.NetworkLog} */ (target.model(WebInspector.NetworkLog));
 }
@@ skipping 126 matching lines @@
  * @param {!WebInspector.NetworkRequest} mainRequest
  */
 WebInspector.PageLoad = function(mainRequest)
 {
     this.id = ++WebInspector.PageLoad._lastIdentifier;
     this.url = mainRequest.url;
     this.startTime = mainRequest.startTime;
 }
 
 WebInspector.PageLoad._lastIdentifier = 0;