[DevTools] Make resource tree model optional

third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

 /*
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.Object}
  */
@@ skipping 13 matching lines @@
 WebInspector.TargetManager.Events = {
     InspectedURLChanged: "InspectedURLChanged",
     MainFrameNavigated: "MainFrameNavigated",
     Load: "Load",
     PageReloadRequested: "PageReloadRequested",
     WillReloadPage: "WillReloadPage",
     TargetDisposed: "TargetDisposed",
     SuspendStateChanged: "SuspendStateChanged"
 }
 
+WebInspector.TargetManager._ListenersSymbol = Symbol("WebInspector.TargetManager.Listeners");

[dgozman, 2016/08/19 20:23:37]

style: _listenersSymbol

[eostroukhov, 2016/08/20 01:22:31]

Done.

+
 WebInspector.TargetManager.prototype = {
     suspendAllTargets: function()
     {
         if (this._isSuspended)
             return;
         this._isSuspended = true;
         this.dispatchEventToListeners(WebInspector.TargetManager.Events.SuspendStateChanged);
 
         for (var i = 0; i < this._targets.length; ++i) {
             for (var model of this._targets[i].models())
@@ skipping 48 matching lines @@
     {
         this.dispatchEventToListeners(event.type, event.data);
     },
 
     /**
      * @param {boolean=} bypassCache
      * @param {string=} injectedScript
      */
     reloadPage: function(bypassCache, injectedScript)
     {
-        if (this._targets.length)
-            this._targets[0].resourceTreeModel.reloadPage(bypassCache, injectedScript);
+        if (!this._targets.length)
+            return;
+
+        var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this._targets[0]);
+        if (!resourceTreeModel)
+            return;
+
+        resourceTreeModel.reloadPage(bypassCache, injectedScript);
     },
 
     /**
      * @param {!Function} modelClass
      * @param {string} eventType
      * @param {function(!WebInspector.Event)} listener
      * @param {!Object=} thisObject
      */
     addModelListener: function(modelClass, eventType, listener, thisObject)
     {
@@ skipping 65 matching lines @@
     createTarget: function(name, capabilitiesMask, connection, parentTarget)
     {
         var target = new WebInspector.Target(this, name, capabilitiesMask, connection, parentTarget);
 
         /** @type {!WebInspector.ConsoleModel} */
         target.consoleModel = new WebInspector.ConsoleModel(target);
         /** @type {!WebInspector.RuntimeModel} */
         target.runtimeModel = new WebInspector.RuntimeModel(target);
 
         var networkManager = null;
-        if (target.hasNetworkCapability())
+        var resourceTreeModel = null;
+        if (target.hasNetworkCapability()) {
             networkManager = new WebInspector.NetworkManager(target);
-
-        var securityOriginManager = WebInspector.SecurityOriginManager.fromTarget(target);
-        /** @type {!WebInspector.ResourceTreeModel} */
-        target.resourceTreeModel = new WebInspector.ResourceTreeModel(target, networkManager, securityOriginManager);
-
-        if (networkManager)
-            new WebInspector.NetworkLog(target, target.resourceTreeModel, networkManager);
+            if (target.hasDOMCapability()) {
+                var securityOriginManager = WebInspector.SecurityOriginManager.fromTarget(target);

[dgozman, 2016/08/19 20:23:37]

Inline this one?

[eostroukhov, 2016/08/20 01:22:31]

Done.

+                resourceTreeModel = new WebInspector.ResourceTreeModel(target, networkManager, securityOriginManager);
+                new WebInspector.NetworkLog(target, resourceTreeModel, networkManager);

[dgozman, 2016/08/19 20:23:37]

nit: let's avoid nested if's here. Instead I propose to list all dependencies in
each if statement, e.g.:

if (resourceTreeModel && networkManager)
    new WebInspector.NetworkLog(target, resourceTreeModel, networkManager);

[eostroukhov, 2016/08/20 01:22:31]

Done.

+            }
+        }
 
         if (target.hasJSCapability())
             new WebInspector.DebuggerModel(target);
 
-        if (target.hasDOMCapability()) {
+        if (resourceTreeModel) {

[dgozman, 2016/08/19 20:23:37]

Why this change? If DOMModel or CSSModel cannot work without ResourceTreeModel,
why don't we pass it in constructor?

[eostroukhov, 2016/08/20 01:22:31]

I was trying to do this in an earlier CL - ultimately we decided against it as
it looks like the CSSModel should not depend on RTM but this can't be fixed
right now.

[dgozman, 2016/08/20 01:32:00]

Let's add a TODO here then.

[eostroukhov-old, 2016/08/22 17:55:41]

Done.

             var domModel = new WebInspector.DOMModel(target);
             new WebInspector.CSSModel(target, domModel);
         }
 
         /** @type {?WebInspector.WorkerManager} */
         target.workerManager = target.hasWorkerCapability() ? new WebInspector.WorkerManager(target) : null;
         /** @type {!WebInspector.CPUProfilerModel} */
         target.cpuProfilerModel = new WebInspector.CPUProfilerModel(target);
         /** @type {!WebInspector.HeapProfilerModel} */
         target.heapProfilerModel = new WebInspector.HeapProfilerModel(target);
@@ skipping 16 matching lines @@
         return this._observers.filter((observer) => target.hasAllCapabilities(observer[this._observerCapabiliesMaskSymbol] || 0));
     },
 
     /**
      * @param {!WebInspector.Target} target
      */
     addTarget: function(target)
     {
         this._targets.push(target);
         if (this._targets.length === 1) {
-            target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._redispatchEvent, this);
-            target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.Load, this._redispatchEvent, this);
-            target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.PageReloadRequested, this._redispatchEvent, this);
-            target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.WillReloadPage, this._redispatchEvent, this);
+            var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(target);
+            if (resourceTreeModel) {
+                var listeners = [];
+                listeners.push(resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._redispatchEvent, this));

[dgozman, 2016/08/19 20:23:37]

nit: instead of push, we can inline:
resourceTreeModel[symbol] = [
    ...,
    ...,
];

[eostroukhov, 2016/08/20 01:22:31]

Done.

+                listeners.push(resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.Load, this._redispatchEvent, this));
+                listeners.push(resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.PageReloadRequested, this._redispatchEvent, this));
+                listeners.push(resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.WillReloadPage, this._redispatchEvent, this));
+                resourceTreeModel[WebInspector.TargetManager._ListenersSymbol] = listeners;
+            }
         }
         var copy = this._observersForTarget(target);
         for (var i = 0; i < copy.length; ++i)
             copy[i].targetAdded(target);
 
         for (var eventType in this._modelListeners) {
             var listeners = this._modelListeners[eventType];
             for (var i = 0; i < listeners.length; ++i) {
                 var model = target.model(listeners[i].modelClass);
                 if (model)
                     model.addEventListener(eventType, listeners[i].listener, listeners[i].thisObject);
             }
         }
     },
 
     /**
      * @param {!WebInspector.Target} target
      */
     removeTarget: function(target)
     {
         this._targets.remove(target);
-        if (this._targets.length === 0) {
-            target.resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._redispatchEvent, this);
-            target.resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.Load, this._redispatchEvent, this);
-            target.resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.WillReloadPage, this._redispatchEvent, this);
-        }
+        var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(target);
+        var treeModelListeners = resourceTreeModel && resourceTreeModel[WebInspector.TargetManager._ListenersSymbol];
+        if (treeModelListeners)
+            WebInspector.EventTarget.removeEventListeners(treeModelListeners);
+
         var copy = this._observersForTarget(target);
         for (var i = 0; i < copy.length; ++i)
             copy[i].targetRemoved(target);
 
         for (var eventType in this._modelListeners) {
             var listeners = this._modelListeners[eventType];
             for (var i = 0; i < listeners.length; ++i) {
                 var model = target.model(listeners[i].modelClass);
                 if (model)
                     model.removeEventListener(eventType, listeners[i].listener, listeners[i].thisObject);
@@ skipping 74 matching lines @@
     /**
      * @param {!WebInspector.Target} target
      */
     targetRemoved: function(target) { },
 }
 
 /**
  * @type {!WebInspector.TargetManager}
  */
 WebInspector.targetManager = new WebInspector.TargetManager();