[Autofill] Add metrics to determine whether the system AddressBook is accessible.

[Autofill] Add metrics to determine whether the system AddressBook is accessible.

These metrics should help us understand whether users are ok with granting
Chrome access to their "Me" card for Autofill or if the system's permissions
dialog scares them away.

BUG=355516
TEST=none
R=asvitkine@chromium.org, pinkerton@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260057

[Alexei Svitkine (slow), 2014-03-26 13:28:15]

LGTM with a nit

https://codereview.chromium.org/212233002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/212233002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:1474: +    Whether the Mac AddressBook
was available on the *first* attempt to read
Nit: Might be good to clarify what *first* means in this case. I originally read
this as *first* within a session, but it looks like you're saving a pref - so is
it "first attempt ever for a given profile"?

[Ilya Sherman, 2014-03-27 01:30:09]

https://codereview.chromium.org/212233002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/212233002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:1474: +    Whether the Mac AddressBook
was available on the *first* attempt to read
On 2014/03/26 13:28:15, Alexei Svitkine wrote:
> Nit: Might be good to clarify what *first* means in this case. I originally
read
> this as *first* within a session, but it looks like you're saving a pref - so
is
> it "first attempt ever for a given profile"?

Done.

[Ilya Sherman, 2014-03-27 18:26:53]

Adding some more Mac folks as reviewers, since pink seems busy.

[pink (ping after 24hrs), 2014-03-27 18:36:28]

LGTM with one typo nit.

https://codereview.chromium.org/212233002/diff/50001/components/autofill/core...
File components/autofill/core/common/autofill_pref_names.cc (right):

https://codereview.chromium.org/212233002/diff/50001/components/autofill/core...
components/autofill/core/common/autofill_pref_names.cc:16: // profiles has been
issued.  Currently applies only to auxiliar profiles on
auxiliary?

[Ilya Sherman, 2014-03-27 19:08:56]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2014-03-27 19:09:07]

Thanks!

https://codereview.chromium.org/212233002/diff/50001/components/autofill/core...
File components/autofill/core/common/autofill_pref_names.cc (right):

https://codereview.chromium.org/212233002/diff/50001/components/autofill/core...
components/autofill/core/common/autofill_pref_names.cc:16: // profiles has been
issued.  Currently applies only to auxiliar profiles on
On 2014/03/27 18:36:28, pink wrote:
> auxiliary?

Done.

[commit-bot: I haz the power, 2014-03-27 19:11:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/212233002/70001

[commit-bot: I haz the power, 2014-03-27 23:54:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 23:54:52]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[Ilya Sherman, 2014-03-28 01:37:09]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2014-03-28 01:38:50]

The CQ bit was unchecked by isherman@chromium.org

[commit-bot: I haz the power, 2014-03-28 01:38:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/212233002/70001

[Ilya Sherman, 2014-03-28 01:38:51]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-03-28 01:42:07]

Change committed as 260057

[Mark Mentovai, 2014-04-01 19:14:41]

LGTM