Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2122303003: Remove kOzoneTestSingleOverlaySupport. (Closed)

Created:
4 years, 5 months ago by Daniele Castagna
Modified:
4 years, 5 months ago
Reviewers:
dnicoara, reveman, ccameron
CC:
asvitkine+watch_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove kOzoneTestSingleOverlaySupport. kOzoneTestSingleOverlaySupport was originally added to test a single overlay plane when using Ozone. The code evolved and now passing that parameter enable overlays (not only a single overlay). This CL removes the command line flag and uses kEnableHardwareOverlays instead to enable overlays on Ozone. BUG=b/29430506 Committed: https://crrev.com/8484d565379e3aa2df9db03eba7c5eddfebb34fd Cr-Commit-Position: refs/heads/master@{#405606}

Patch Set 1 #

Patch Set 2 : Fix compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -32 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 1 chunk +5 lines, -7 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_overlay_manager.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/host/drm_overlay_manager.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M ui/ozone/public/ozone_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/public/ozone_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Daniele Castagna
What do you guys think about getting rid of this flag?
4 years, 5 months ago (2016-07-14 19:32:02 UTC) #3
reveman
lgtm
4 years, 5 months ago (2016-07-14 19:33:49 UTC) #4
dnicoara
lgtm
4 years, 5 months ago (2016-07-14 19:40:59 UTC) #5
Daniele Castagna
+chris for ownership.
4 years, 5 months ago (2016-07-14 19:58:40 UTC) #7
ccameron
lgtm
4 years, 5 months ago (2016-07-14 21:17:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122303003/20001
4 years, 5 months ago (2016-07-14 21:20:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 22:30:18 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 22:30:20 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 22:32:47 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8484d565379e3aa2df9db03eba7c5eddfebb34fd
Cr-Commit-Position: refs/heads/master@{#405606}

Powered by Google App Engine
This is Rietveld 408576698