chrome/common/shell_handler_win.mojom - Issue 2122303002: Revive experiment to isolate shell operations.

Side by Side Diff: chrome/common/shell_handler_win.mojom

Issue 2122303002: Revive experiment to isolate shell operations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/win/chrome_select_file_dialog_factory.cc ('K') | « chrome/common/chrome_utility_messages.h ('k') | chrome/common/shell_handler_win.typemap » ('j') | chrome/common/shell_handler_win.typemap » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module mojom;	5 module mojom;

6	6

	7 import "mojo/common/common_custom_types.mojom";

	8

	9 [Native]

	10 struct FileExtensionFilters;

	11

7 interface ShellHandler {	12 interface ShellHandler {

8 // Returns the pinned state of the current executable.	13 // Returns the pinned state of the current executable.

9 IsPinnedToTaskbar() => (bool succeeded, bool is_pinned_to_taskbar);	14 IsPinnedToTaskbar() => (bool succeeded, bool is_pinned_to_taskbar);

	15

	16 // Instructs the utility process to invoke GetOpenFileName. \|owner\| is the
	sky 2016/07/08 15:28:20 document what owner is, e.g. an HWND. document what owner is, e.g. an HWND. Patrick Monette 2016/07/08 19:36:10 Done. Show quoted text On 2016/07/08 15:28:20, sky wrote: > document what owner is, e.g. an HWND. Done.
	17 // parent of the modal dialog, \|flags\| are OFN_* flags. \|filter\| constrains th e
	sky 2016/07/08 15:28:21 nit: < 80 nit: < 80 Patrick Monette 2016/07/08 19:36:10 Done. Any suggestions on the formatting? Maybe the Show quoted text On 2016/07/08 15:28:21, sky wrote: > nit: < 80 Done. Any suggestions on the formatting? Maybe the formatter should be able to handle mojom files :) sky 2016/07/08 20:47:14 I try to follow what I think git cl format would d Show quoted text On 2016/07/08 19:36:10, Patrick Monette wrote: > On 2016/07/08 15:28:21, sky wrote: > > nit: < 80 > > Done. Any suggestions on the formatting? Maybe the formatter should be able to > handle mojom files :) I try to follow what I think git cl format would do. By that I mean a single argument per line, wrapping at 80...
	18 // user's file choices. \|initial_directory\| and \|filename\| select the director y

	19 // to be displayed and the file to be initially selected.
	sky 2016/07/08 15:28:21 Document what the result is if the user cancels th Document what the result is if the user cancels the selection. Patrick Monette 2016/07/08 19:36:10 Done. Show quoted text On 2016/07/08 15:28:21, sky wrote: > Document what the result is if the user cancels the selection. Done.
	20 DoGetOpenFileName(uint64 owner, uint32 flags, FileExtensionFilters filters, mo jo.common.mojom.FilePath initial_directory, mojo.common.mojom.FilePath filename) => (mojo.common.mojom.FilePath directory, array<mojo.common.mojom.FilePath> fil es);

	21

	22 DoGetSaveFileName(uint64 owner, uint32 flags, FileExtensionFilters filters, ui nt32 one_based_filter_index, mojo.common.mojom.FilePath initial_directory, mojo. common.mojom.FilePath suggested_filename, mojo.common.mojom.FilePath default_ext ension) => (mojo.common.mojom.FilePath path, uint32 one_based_filter_index);
	sky 2016/07/08 15:28:21 Document what one_based_filter_index means. Document what one_based_filter_index means. Patrick Monette 2016/07/08 19:36:10 Done. Show quoted text On 2016/07/08 15:28:21, sky wrote: > Document what one_based_filter_index means. Done.
10 };	23 };

OLD	NEW