Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 21223003: Reland initial bits of "Implement correct OS and CC detection." (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer
Modified:
7 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Reland initial bits of "Implement correct OS and CC detection." This adds the OS and CC detection and cleans up the globals.h to some degree. It also places all of the C++11 feature detection into globals.h. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -144 lines) Patch
M src/checks.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/globals.h View 5 chunks +251 lines, -141 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
First part of the OS/CC detection change.
7 years, 4 months ago (2013-07-30 08:50:31 UTC) #1
Sven Panne
LGTM. May the build bots be with you! :-)
7 years, 4 months ago (2013-07-30 10:34:18 UTC) #2
Benedikt Meurer
7 years, 4 months ago (2013-07-30 10:37:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15953 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698