Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2122293002: Revert of Roll src/third_party/skia/ 1e2a702c1..4be9a30ae (5 commits). (Closed)

Created:
4 years, 5 months ago by sgurun-gerrit only
Modified:
4 years, 5 months ago
CC:
chromium-reviews, rmistry
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/skia/ 1e2a702c1..4be9a30ae (5 commits). (patchset #1 id:1 of https://codereview.chromium.org/2125883002/ ) Reason for revert: Reverting speculatively since the android_webview test apk and chrome_public_test_apk started failing. I will revert the revert if this is not the reason. Original issue's description: > Roll src/third_party/skia/ 1e2a702c1..4be9a30ae (5 commits). > > https://chromium.googlesource.com/skia.git/+log/1e2a702c1959..4be9a30aed39 > > $ git log 1e2a702c1..4be9a30ae --date=short --no-merges --format='%ad %ae %s' > 2016-07-06 bsalomon Increase batching for AA fill rects. > 2016-07-06 ethannicholas fix for Clang 3.8 warning in SkSL GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2118033002 > 2016-07-06 benjaminwagner Blacklist fontscalerdistortable on Win8. > 2016-07-06 bsalomon Enlarge strokerect GM size to reveal hidden content GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126723002 > 2016-07-06 fmalita Document SkSurface::MakeRaster's memory initialization > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > TBR=rmistry@google.com > > Committed: https://crrev.com/c862d885af12c6d922fda7a1d082cbe7e8500fdc > Cr-Commit-Position: refs/heads/master@{#403911} TBR=rmistry@google.com,skia-deps-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/78e5449e0c5b2ba4bea021f078621b207e0b3f66 Cr-Commit-Position: refs/heads/master@{#403930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
sgurun-gerrit only
Created Revert of Roll src/third_party/skia/ 1e2a702c1..4be9a30ae (5 commits).
4 years, 5 months ago (2016-07-06 17:41:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122293002/1
4 years, 5 months ago (2016-07-06 17:41:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 17:43:02 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 17:43:06 UTC) #6
sgurun-gerrit only
On 2016/07/06 17:41:47, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 5 months ago (2016-07-06 17:44:37 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78e5449e0c5b2ba4bea021f078621b207e0b3f66 Cr-Commit-Position: refs/heads/master@{#403930}
4 years, 5 months ago (2016-07-06 17:46:12 UTC) #9
sgurun-gerrit only
4 years, 5 months ago (2016-07-06 19:47:54 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2122073003/ by sgurun@chromium.org.

The reason for reverting is: the revert did not help, reverting the revert.

Bug: 626042.

Powered by Google App Engine
This is Rietveld 408576698