Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2122283002: mac: Stop using deprecated FSRef functions in service_process_util_mac.mm

Created:
4 years, 5 months ago by Nico
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Stop using deprecated FSRef functions in service_process_util_mac.mm Instead of an FSRef, use a fileReferenceURL, the replacement. The replacement function to check if a file is in the trash only exists in 10.10+, but the old way was deprecated in 10.8, so call the new code on 10.10+ and call the old code on 10.9 (we can delete that code path once we stop supporting 10.9). No behavior change intended. BUG=74983, 622481 TEST= https://bugs.chromium.org/p/chromium/issues/detail?id=74983#c16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -34 lines) Patch
M chrome/common/service_process_util_mac.mm View 6 chunks +67 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
Nico
Description was changed from ========== mac: Stop using deprecated FSRef functions in service_process_util_mac.mm BUG=74983,622481 ========== ...
4 years, 5 months ago (2016-07-06 17:29:49 UTC) #1
Nico
Description was changed from ========== mac: Stop using deprecated FSRef functions in service_process_util_mac.mm Instead of ...
4 years, 5 months ago (2016-07-06 17:30:07 UTC) #2
Nico
4 years, 5 months ago (2016-07-06 19:28:52 UTC) #3
Description was changed from

==========
mac: Stop using deprecated FSRef functions in service_process_util_mac.mm

Instead of an FSRef, use a fileReferenceURL, the replacement.

The replacement function to check if a file is in the trash
only exists in 10.10+, but the old way was deprecated in 10.8,
so call the new code on 10.10+ and call the old code on 10.9
(we can delete that code path once we stop supporting 10.9).

No behavior change intended.

BUG=74983,622481
TEST=https://bugs.chromium.org/p/chromium/issues/detail?id=74983#c16
==========

to

==========
mac: Stop using deprecated FSRef functions in service_process_util_mac.mm

Instead of an FSRef, use a fileReferenceURL, the replacement.

The replacement function to check if a file is in the trash
only exists in 10.10+, but the old way was deprecated in 10.8,
so call the new code on 10.10+ and call the old code on 10.9
(we can delete that code path once we stop supporting 10.9).

No behavior change intended.

BUG=74983,622481
TEST= https://bugs.chromium.org/p/chromium/issues/detail?id=74983#c16
==========

Powered by Google App Engine
This is Rietveld 408576698