Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2122273002: Merge some repeated code in ImageBitmapFactories into a helper function (Closed)

Created:
4 years, 5 months ago by xidachen
Modified:
4 years, 5 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge some repeated code in ImageBitmapFactories into a helper function TBR=junov@chromium.org Committed: https://crrev.com/72208cde1c0f60aea5ffa963f3d0410e854905cc Cr-Commit-Position: refs/heads/master@{#404044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 3 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122273002/1
4 years, 5 months ago (2016-07-06 17:25:43 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99113)
4 years, 5 months ago (2016-07-06 19:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122273002/1
4 years, 5 months ago (2016-07-07 01:39:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 02:45:51 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 02:46:04 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 02:48:18 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/72208cde1c0f60aea5ffa963f3d0410e854905cc
Cr-Commit-Position: refs/heads/master@{#404044}

Powered by Google App Engine
This is Rietveld 408576698