Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2122263004: Don't report single find match after all matches have already been reported. (Closed)

Created:
4 years, 5 months ago by paulmeyer
Modified:
4 years, 5 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't report single find match after all matches have already been reported. There is a place in RenderFrameImpl::OnFind where after one find match is found, it reports that single match just to indicate that there is at least one match in the frame. This is useful when searching the frame for the first time, but pretty meaningless during a "find next" request since the whole frame will have already been searched and all of the matches reported beforehand. It's also detrimental since it will temporarily lower the global match count and then have to recalculate various things when it goes back up. This patch prevents this single match reply during "find next" requests. BUG=457440 Committed: https://crrev.com/8d7aa843119033dc876d3017931d0272d048b20e Cr-Commit-Position: refs/heads/master@{#406008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
paulmeyer
4 years, 5 months ago (2016-07-07 19:16:19 UTC) #3
ncarter (slow)
lgtm. I think I'd seen these IPCs arrive when debugging the browser process side, and ...
4 years, 5 months ago (2016-07-07 19:50:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122263004/1
4 years, 5 months ago (2016-07-07 20:51:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-07 22:53:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-07 22:53:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122263004/1
4 years, 5 months ago (2016-07-18 14:20:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 16:08:23 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 16:08:36 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 16:11:35 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d7aa843119033dc876d3017931d0272d048b20e
Cr-Commit-Position: refs/heads/master@{#406008}

Powered by Google App Engine
This is Rietveld 408576698