Add new Ozone surface API.

Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

Small build file change to remove an unnecessary dep on //ui/base from
//ui/gl. Since it was in public_deps, a few downstream changes to
targets that depend on //ui/gl are needed as well.

This is the start of step 3 in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b598dffa8b18b1fbdc606e5db7c182ee5918ad84
Cr-Commit-Position: refs/heads/master@{#406922}

[kylechar, 2016-07-06 17:35:37]

kylechar@chromium.org changed reviewers:
+ dnicoara@chromium.org, spang@chromium.org

[kylechar, 2016-07-06 17:35:37]

Here is my proposed new API for surface creation from Ozone. Thoughts? 

There is the same dep problem again from crrev.com/2096533003 where I'm moving
the helper methods into SurfaceFactoryOzone. An alternative is to move the
callback typedefs out of SurfaceFactoryOzone and into egl_util.cc/h.

[kylechar, 2016-07-06 17:38:31]

Description was changed from

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

SurfaceFactoryOzone needs to be moved from //ui/ozone:ozone_base to
//ui/ozone:platform. This is because of a circular dependency that is
formed by the following targets if we want to use GLSurface from
//ui/ozone:ozone_base.

//ui/gl
//ui/base
//ui/ozone:ozone_base
//ui/gl

Some utility code is moved as a result of moving SurfaceFactoryOzone.

This is the start of step 3 in the associated bug.

BUG=625876
==========

to

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

SurfaceFactoryOzone needs to be moved from //ui/ozone:ozone_base to
//ui/ozone:platform. This is because of a circular dependency that is
formed by the following targets if we want to use GLSurface from
//ui/ozone:ozone_base.

//ui/gl
//ui/base
//ui/ozone:ozone_base
//ui/gl

Some utility code is moved as a result of moving SurfaceFactoryOzone.

This is the start of step 3 in the associated bug.

BUG=611142
==========

[spang, 2016-07-06 18:07:02]

Can you fix the dependency from ui/gl to ui/base instead?

ui/base contains a lot of cruft, ui/gl really should not be using that.

[spang, 2016-07-06 18:08:23]

On 2016/07/06 18:07:02, spang wrote:
> Can you fix the dependency from ui/gl to ui/base instead?
> 
> ui/base contains a lot of cruft, ui/gl really should not be using that.

It looks like it only needs //ui/base/x which is much smaller than //ui/base. If
you narrow it to that, does it work?

[kylechar, 2016-07-06 18:35:16]

Description was changed from

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

SurfaceFactoryOzone needs to be moved from //ui/ozone:ozone_base to
//ui/ozone:platform. This is because of a circular dependency that is
formed by the following targets if we want to use GLSurface from
//ui/ozone:ozone_base.

//ui/gl
//ui/base
//ui/ozone:ozone_base
//ui/gl

Some utility code is moved as a result of moving SurfaceFactoryOzone.

This is the start of step 3 in the associated bug.

BUG=611142
==========

to

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

SurfaceFactoryOzone needs to be moved from //ui/ozone:ozone_base to
//ui/ozone:platform. This is because of a circular dependency that is
formed by the following targets if we want to use GLSurface from
//ui/ozone:ozone_base.

//ui/gl
//ui/base
//ui/ozone:ozone_base
//ui/gl

Some utility code is moved as a result of moving SurfaceFactoryOzone.

This is the start of step 3 in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2016-07-06 18:35:35]

Short answer: yes.

[spang, 2016-07-06 19:13:30]

lgtm

[spang, 2016-07-06 19:16:29]

Description was changed from

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

SurfaceFactoryOzone needs to be moved from //ui/ozone:ozone_base to
//ui/ozone:platform. This is because of a circular dependency that is
formed by the following targets if we want to use GLSurface from
//ui/ozone:ozone_base.

//ui/gl
//ui/base
//ui/ozone:ozone_base
//ui/gl

Some utility code is moved as a result of moving SurfaceFactoryOzone.

This is the start of step 3 in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

This is the start of step 3 in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2016-07-07 14:07:29]

Description was changed from

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

This is the start of step 3 in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

Small build file change to remove an unnecessary dep on //ui/base from
//ui/gl. Since it was in public_deps, a few downstream changes to
targets that depend on //ui/gl are needed as well.

This is the start of step 3 in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2016-07-07 14:07:46]

kylechar@chromium.org changed reviewers:
+ sievers@chromium.org
- dnicoara@chromium.org

[kylechar, 2016-07-07 14:07:47]

+sievers for ui/gl/* and gpu/* GN/GYP file changes.

[no sievers, 2016-07-07 17:31:40]

Can you also update ui/gl/DEPS to specific ui/base/x instead of ui/base?

https://codereview.chromium.org/2122243002/diff/20001/ui/gl/BUILD.gn
File ui/gl/BUILD.gn (right):

https://codereview.chromium.org/2122243002/diff/20001/ui/gl/BUILD.gn#newcode180
ui/gl/BUILD.gn:180: deps += [ "//ui/base/x/" ]
should this be in the |use_x11| above?

The include from gl_surface_egl.cc already has 'nogncheck' so I assume it
doesn't matter?
Or can we remove the nogncheck and leave this as a general dependency here?

[kylechar, 2016-07-07 18:04:12]

https://codereview.chromium.org/2122243002/diff/20001/ui/gl/BUILD.gn
File ui/gl/BUILD.gn (right):

https://codereview.chromium.org/2122243002/diff/20001/ui/gl/BUILD.gn#newcode180
ui/gl/BUILD.gn:180: deps += [ "//ui/base/x/" ]
On 2016/07/07 17:31:40, sievers wrote:
> should this be in the |use_x11| above?
> 
> The include from gl_surface_egl.cc already has 'nogncheck' so I assume it
> doesn't matter?
> Or can we remove the nogncheck and leave this as a general dependency here?

So this is in the |use_x11| if statement, but that's all sort of moot. I took a
closer look at that included header and I don't think any symbols from it are
even used. So just removed the header, removed the build deps and removed it
from DEPS.

[no sievers, 2016-07-07 22:07:58]

On 2016/07/07 18:04:12, kylechar wrote:
> https://codereview.chromium.org/2122243002/diff/20001/ui/gl/BUILD.gn
> File ui/gl/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2122243002/diff/20001/ui/gl/BUILD.gn#newcode180
> ui/gl/BUILD.gn:180: deps += [ "//ui/base/x/" ]
> On 2016/07/07 17:31:40, sievers wrote:
> > should this be in the |use_x11| above?
> > 
> > The include from gl_surface_egl.cc already has 'nogncheck' so I assume it
> > doesn't matter?
> > Or can we remove the nogncheck and leave this as a general dependency here?
> 
> So this is in the |use_x11| if statement, but that's all sort of moot. I took
a
> closer look at that included header and I don't think any symbols from it are
> even used. So just removed the header, removed the build deps and removed it
> from DEPS.

lgtm!

[kylechar, 2016-07-21 13:49:23]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-07-21 13:49:23]

The patchset sent to the CQ was uploaded after l-g-t-m from spang@chromium.org,
sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2122243002/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-07-21 13:49:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 13:49:39]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-21 13:52:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 13:52:14]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kylechar, 2016-07-21 14:02:11]

Description was changed from

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

Small build file change to remove an unnecessary dep on //ui/base from
//ui/gl. Since it was in public_deps, a few downstream changes to
targets that depend on //ui/gl are needed as well.

This is the start of step 3 in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

Small build file change to remove an unnecessary dep on //ui/base from
//ui/gl. Since it was in public_deps, a few downstream changes to
targets that depend on //ui/gl are needed as well.

This is the start of step 3 in the associated bug.

BUG=611142
==========

[kylechar, 2016-07-21 14:05:55]

Description was changed from

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

Small build file change to remove an unnecessary dep on //ui/base from
//ui/gl. Since it was in public_deps, a few downstream changes to
targets that depend on //ui/gl are needed as well.

This is the start of step 3 in the associated bug.

BUG=611142
==========

to

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

Small build file change to remove an unnecessary dep on //ui/base from
//ui/gl. Since it was in public_deps, a few downstream changes to
targets that depend on //ui/gl are needed as well.

This is the start of step 3 in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2016-07-21 14:07:31]

kylechar@chromium.org changed reviewers:
+ tsepez@chromium.org

[kylechar, 2016-07-21 14:07:31]

+tsepez for gpu/ipc/common/BUILD.gn change.

[kylechar, 2016-07-21 14:09:19]

Patchset #5 (id:80001) has been deleted

[kylechar, 2016-07-21 15:00:11]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 15:00:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-07-21 16:17:07]

ipc LGTM

[commit-bot: I haz the power, 2016-07-21 18:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 18:45:47]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-07-21 18:49:27]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-07-21 18:49:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
sievers@chromium.org, spang@chromium.org
Link to the patchset: https://codereview.chromium.org/2122243002/#ps120001
(title: "Even more deps.")

[commit-bot: I haz the power, 2016-07-21 18:49:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 18:54:18]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-07-21 18:55:54]

Description was changed from

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

Small build file change to remove an unnecessary dep on //ui/base from
//ui/gl. Since it was in public_deps, a few downstream changes to
targets that depend on //ui/gl are needed as well.

This is the start of step 3 in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add new Ozone surface API.

This CL adds the new API for how ozone platforms will create GLSurfaces.
Now that //ui/ozone can depend on //ui/gl, the platform can create a
GLSurface directly. SurfaceFactoryOzone has methods added for creating
regular, surfaceless and offscreen surfaces. It also has a temporary
method that will allow us to switch platforms over one by one.

Small build file change to remove an unnecessary dep on //ui/base from
//ui/gl. Since it was in public_deps, a few downstream changes to
targets that depend on //ui/gl are needed as well.

This is the start of step 3 in the associated bug.

BUG=611142
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b598dffa8b18b1fbdc606e5db7c182ee5918ad84
Cr-Commit-Position: refs/heads/master@{#406922}
==========

[commit-bot: I haz the power, 2016-07-21 18:55:56]

Patchset 6 (id:??) landed as
https://crrev.com/b598dffa8b18b1fbdc606e5db7c182ee5918ad84
Cr-Commit-Position: refs/heads/master@{#406922}