Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2122233002: Revert of Roll ANGLE 474a08c..3820e9c (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll ANGLE 474a08c..3820e9c (patchset #1 id:1 of https://codereview.chromium.org/2126623002/ ) Reason for revert: Broke ARM chrome compile on chromeos: chromeos-chrome-54.0.2789.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/angle/src/image_util/loadimage_sse2.cpp:17:23: fatal error: emmintrin.h: No such file or directory chromeos-chrome-54.0.2789.0_rc-r1: #include <emmintrin.h> chromeos-chrome-54.0.2789.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/angle/src/image_util/loadimage_sse2.cpp:17:23: fatal error: emmintrin.h: No such file or directory chromeos-chrome-54.0.2789.0_rc-r1: #include <emmintrin.h> NOTRY=true NOTREECHECKS=true Original issue's description: > Roll ANGLE 474a08c..3820e9c > > https://chromium.googlesource.com/angle/angle.git/+log/474a08c..3820e9c > > BUG=chromium:625363, 612205, chromium:616176, 407309 > > TBR=jmadill@chromium.org > > TEST=bots > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel > > Committed: https://crrev.com/6f88ffc45920456f0840acf3299c0a5e24bdebc9 > Cr-Commit-Position: refs/heads/master@{#403788} TBR=jmadill@chromium.org,geofflang@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:625363, 612205, chromium:616176, 407309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
James Cook
Created Revert of Roll ANGLE 474a08c..3820e9c
4 years, 5 months ago (2016-07-06 16:58:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122233002/1
4 years, 5 months ago (2016-07-06 16:59:03 UTC) #3
Jamie Madill
not lgtm, james let's roll forward with ANGLE, reverting the roll could break cq bots ...
4 years, 5 months ago (2016-07-06 17:02:19 UTC) #5
James Cook
4 years, 5 months ago (2016-07-06 17:03:22 UTC) #6
On 2016/07/06 17:01:36, Jamie Madill wrote:
> The CQ bit was unchecked by mailto:jmadill@chromium.org

Thanks. Talked to geofflang, Angle is going to roll forward with a fix, not
back.

Powered by Google App Engine
This is Rietveld 408576698