Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5250)

Unified Diff: chrome/browser/about_flags.cc

Issue 212223012: Disable app list folders by default for non-ChromeOS platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use a combobox option for chrome:flags Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | ui/app_list/app_list_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index a8ffdc201296e3a34510dcd7fb1e06a9adff7d48..339ba8b1756756038fd8c1767f6f27275b4e0227 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -401,6 +401,14 @@ const Experiment::Choice kTouchScrollingModeChoices[] = {
switches::kTouchScrollingModeSyncTouchmove },
};
+const Experiment::Choice kEnableAppListFoldersChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
+ app_list::switches::kEnableFolderUI, "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
+ app_list::switches::kDisableFolderUI, "" },
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the experiment is the internal name. If you'd like to
@@ -1531,11 +1539,11 @@ const Experiment kExperiments[] = {
},
#endif
{
- "disable-app-list-folder-ui",
- IDS_FLAGS_DISABLE_APP_LIST_FOLDER,
- IDS_FLAGS_DISABLE_APP_LIST_FOLDER_DESCRIPTION,
+ "app-list-folder-ui",
+ IDS_FLAGS_ENABLE_APP_LIST_FOLDER,
+ IDS_FLAGS_ENABLE_APP_LIST_FOLDER_DESCRIPTION,
kOsWin | kOsLinux | kOsCrOS,
tapted 2014/04/02 04:32:08 drive-by: This should be kOsAll. Otherwise when it
calamity 2014/04/02 04:53:53 Done.
- SINGLE_VALUE_TYPE(app_list::switches::kDisableFolderUI)
+ MULTI_VALUE_TYPE(kEnableAppListFoldersChoices)
},
{
"disable-app-list-voice-search",
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | ui/app_list/app_list_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698