Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 212223007: Add DisableCompositingQueryAsserts to FrameView::useSlowRepaints (Closed)

Created:
6 years, 8 months ago by trchen
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Ian Vollick
Visibility:
Public.

Description

Add DisableCompositingQueryAsserts to FrameView::useSlowRepaints Android build hits this assertion all the time, rendering debug build useless. This disabler isn't entirely correct, but assuming blitting-based scrolling won't last long, it should be okay with a FIXME. BUG=357345 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
trchen
6 years, 8 months ago (2014-04-01 23:20:28 UTC) #1
abarth-chromium
Can we write a test that hits this code path?
6 years, 8 months ago (2014-04-01 23:21:00 UTC) #2
trchen
On 2014/04/01 23:21:00, abarth wrote: > Can we write a test that hits this code ...
6 years, 8 months ago (2014-04-01 23:31:02 UTC) #3
abarth-chromium
Ok. LGTM #ifdefs -> sadness
6 years, 8 months ago (2014-04-01 23:47:22 UTC) #4
trchen
On 2014/04/01 23:47:22, abarth wrote: > Ok. LGTM > > #ifdefs -> sadness FYI, there ...
6 years, 8 months ago (2014-04-01 23:52:27 UTC) #5
trchen
The CQ bit was checked by trchen@chromium.org
6 years, 8 months ago (2014-04-01 23:52:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/212223007/1
6 years, 8 months ago (2014-04-01 23:52:34 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 00:03:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-02 00:03:53 UTC) #9
trchen
The CQ bit was checked by trchen@chromium.org
6 years, 8 months ago (2014-04-02 00:43:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/212223007/1
6 years, 8 months ago (2014-04-02 00:43:13 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 02:30:53 UTC) #12
Message was sent while issue was closed.
Change committed as 170626

Powered by Google App Engine
This is Rietveld 408576698