[CSS Shapes] Simplify RasterShape implementation

[CSS Shapes] Simplify RasterShape implementation

Since only floats can specify shape-outside, the RasterShapeIntervals
class only needs to track the first and last above threshold pixel column
(x1 and x2 in the implementation) for each row. Removed code for dealing with
multiple "runs" per row as well as shape-inside internals.

This is a merge of http://trac.webkit.org/changeset/166522 by Hans Muller <hmuller@adobe.com>;.

BUG=359098
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170716

[rwlbuis, 2014-04-02 14:57:51]

PTAL :)

[Hans Muller, 2014-04-02 15:56:52]

All of the changes look good to me.

[rwlbuis, 2014-04-02 16:05:31]

PTAL

[eseidel, 2014-04-02 19:59:11]

OK rslgtm

https://codereview.chromium.org/212223006/diff/1/Source/core/rendering/shapes...
File Source/core/rendering/shapes/RasterShape.h (right):

https://codereview.chromium.org/212223006/diff/1/Source/core/rendering/shapes...
Source/core/rendering/shapes/RasterShape.h:55: ASSERT(y + m_offset >= 0 &&
static_cast<unsigned>(y + m_offset) < m_intervals.size());
RELEASE_ASSERT?  I guess the Vector already does that.

[rwlbuis, 2014-04-02 20:03:41]

On 2014/04/02 19:59:11, eseidel wrote:
> OK rslgtm
> 
>
https://codereview.chromium.org/212223006/diff/1/Source/core/rendering/shapes...
> File Source/core/rendering/shapes/RasterShape.h (right):
> 
>
https://codereview.chromium.org/212223006/diff/1/Source/core/rendering/shapes...
> Source/core/rendering/shapes/RasterShape.h:55: ASSERT(y + m_offset >= 0 &&
> static_cast<unsigned>(y + m_offset) < m_intervals.size());
> RELEASE_ASSERT?  I guess the Vector already does that.

Correct, at() does that, which is called by the operator[].

[rwlbuis, 2014-04-02 20:03:45]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-04-02 20:03:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/212223006/1

[commit-bot: I haz the power, 2014-04-02 20:13:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 20:13:41]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[rwlbuis, 2014-04-02 21:48:21]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-04-02 21:48:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/212223006/20001

[commit-bot: I haz the power, 2014-04-02 21:59:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 21:59:04]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[rwlbuis, 2014-04-02 22:32:28]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-04-02 22:32:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/212223006/20001

[commit-bot: I haz the power, 2014-04-02 23:24:48]

Change committed as 170716