[Typed-OM] Add CSSTokenStreamValue

third_party/WebKit/Source/core/css/cssom/CSSTokenStreamValue.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CSSTokenStreamValue_h
+#define CSSTokenStreamValue_h
+
+#include "bindings/core/v8/Iterable.h"
+#include "bindings/core/v8/ScriptWrappable.h"
+#include "core/CSSPropertyNames.h"
+#include "core/CoreExport.h"
+#include "core/css/CSSCustomIdentValue.h"
+#include "core/css/CSSPrimitiveValue.h"
+#include "core/css/cssom/CSSStyleValue.h"
+#include "core/css/parser/CSSParserTokenRange.h"
+#include "core/css/parser/CSSPropertyParser.h"

[Timothy Loh, 2016/07/19 03:40:20]

Some of these includes aren't necessary (also in the .cpp file).

[anthonyhkf, 2016/07/19 03:55:15]

Done.

+#include "platform/heap/HeapAllocator.h"
+#include "wtf/Vector.h"
+
+namespace blink {
+
+class CORE_EXPORT CSSTokenStreamValue final : public CSSStyleValue, public ValueIterable<String> {
+    WTF_MAKE_NONCOPYABLE(CSSTokenStreamValue);
+    DEFINE_WRAPPERTYPEINFO();
+public:
+    static CSSTokenStreamValue* create(const Vector<String>& listOfReferences)
+    {
+        return new CSSTokenStreamValue(listOfReferences);
+    }
+
+    CSSValue* toCSSValue() const override;
+
+    StyleValueType type() const override { return TokenStreamType; }
+
+    String referenceAtIndex(int index) { return m_listOfReferences.at(index); }

[Timothy Loh, 2016/07/19 03:40:20]

referenceAtIndex(..) const

[anthonyhkf, 2016/07/19 03:55:15]

Done.

+
+    size_t size() { return m_listOfReferences.size(); }

[Timothy Loh, 2016/07/19 03:40:20]

size() const

[anthonyhkf, 2016/07/19 03:55:15]

Done.

+
+protected:
+    CSSTokenStreamValue(Vector<String> listOfReferences)

[Timothy Loh, 2016/07/19 03:40:20]

const Vector<>& (avoids an extra copy)

[anthonyhkf, 2016/07/19 03:55:15]

Done.

+        : CSSStyleValue()
+        , m_listOfReferences(listOfReferences)
+    {
+    }
+
+private:
+    IterationSource* startIteration(ScriptState*, ExceptionState&) override;
+
+    Vector<String> m_listOfReferences;

[Timothy Loh, 2016/07/19 03:40:20]

listOf is generally avoided. These (going to be) a combination of string
fragments and variable references, so calling these references is misleading.
Maybe m_fragments is better.

[anthonyhkf, 2016/07/19 03:55:15]

Done.

+};
+
+} // namespace blink
+
+#endif // CSSTokenStreamValue_h