[Typed-OM] Add CSSTokenStreamValue

third_party/WebKit/Source/core/css/cssom/CSSTokenStreamValue.h

+#ifndef CSSTokenStreamValue_h
+#define CSSTokenStreamValue_h
+
+#include "bindings/core/v8/Iterable.h"
+#include "bindings/core/v8/ScriptWrappable.h"
+#include "core/CSSPropertyNames.h"
+#include "core/CoreExport.h"
+#include "core/css/CSSCustomIdentValue.h"
+#include "core/css/CSSPrimitiveValue.h"
+#include "core/css/cssom/CSSStyleValue.h"
+#include "core/css/parser/CSSParserTokenRange.h"
+#include "core/css/parser/CSSPropertyParser.h"
+#include "platform/heap/HeapAllocator.h"
+#include "wtf/Vector.h"
+
+namespace blink {
+
+class CORE_EXPORT CSSTokenStreamValueObserver : public GarbageCollectedMixin {

[meade_UTC10, 2016/07/07 05:48:02]

What's this class for? It doesn't seem to be used for anything.

[anthonyhkf, 2016/07/07 08:01:45]

Done.

+public:
+    virtual void valueWasSet() = 0;
+
+    DEFINE_INLINE_VIRTUAL_TRACE() { }
+};
+
+class CORE_EXPORT CSSTokenStreamValue final : public CSSStyleValue,
+    public ValueIterable<String> {

[meade_UTC10, 2016/07/07 05:48:02]

This can be on the previous line (blink doesn't have line length limits- see
also the style guide: https://www.chromium.org/blink/coding-style)

[anthonyhkf, 2016/07/07 08:01:45]

Done.

+    WTF_MAKE_NONCOPYABLE(CSSTokenStreamValue);
+    DEFINE_WRAPPERTYPEINFO();
+public:
+    static CSSTokenStreamValue* create(const Vector<String>& listOfReferences)
+    {
+        return new CSSTokenStreamValue(listOfReferences);
+    }
+
+    CSSValue* toCSSValue() const override;
+
+    StyleValueType type() const override { return TokenStreamType; }
+
+    String componentAtIndex(int index) { return m_listOfReferences.at(index); }

[meade_UTC10, 2016/07/07 05:48:02]

Can this be renamed to referenceAtIndex or something else more descriptive?
(componentAtIndex was used in CSSTransformValue because it contains
CSSTransformComponents, aka components, so you shouldn't keep that name.)

[anthonyhkf, 2016/07/07 08:01:45]

Done.

+
+    Vector<String> listOfReferences() const { return m_listOfReferences; }

[meade_UTC10, 2016/07/07 05:48:02]

Is this function used anywhere?

[anthonyhkf, 2016/07/07 08:01:45]

Done.

+
+    size_t size() { return m_listOfReferences.size(); }
+
+protected:
+    CSSTokenStreamValue(Vector<String> listOfReferences) : CSSStyleValue(),
+        m_listOfReferences(listOfReferences) { }

[meade_UTC10, 2016/07/07 05:48:02]

Constructor line breaking should be like this:

MyClass::MyClass(Document* doc)
    : MySuperClass()
    , m_myMember(0)
    , m_doc(doc)
{
}

https://www.chromium.org/blink/coding-style#TOC-Other-Punctuation

[anthonyhkf, 2016/07/07 08:01:45]

Done.

+
+private:
+    IterationSource* startIteration(ScriptState*, ExceptionState&) override;
+
+    Vector<String> m_listOfReferences;
+};
+
+} // namespace blink
+
+#endif // CSSTokenStreamValue_h