Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2122193002:
cc: transform tree UpdateSnapping before UpdateTargetSpaceTransform (Closed)
Descriptioncc: transform tree UpdateSnapping before UpdateTargetSpaceTransform
We are moving target space transforms from transform tree to property
tree cached data and are going to compute the transforms on demand.
As a result, instead of applying scroll snapping to target space
transforms after we compute each transforms, we can apply it to node's
to_parent transforms before computing.
This CL should not have any effect on behavior and performance.
BUG=624120
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/6328bc770c974f2a5e097108bd968dff1b70205e
Cr-Commit-Position: refs/heads/master@{#404186}
Patch Set 1 #
Messages
Total messages: 16 (8 generated)
Description was changed from ========== cc: transform tree UpdateSnapping before UpdateTargetSpaceTransform We are moving target space transforms from transform tree to property tree cached data and are going to compute the transforms on demand. As a result, instead of applying scroll snapping to target space transforms after we compute each transforms, we can apply it to node's to_parent transforms before computing. This CL should not have any effect on behavior and performance. BUG=624120 ========== to ========== cc: transform tree UpdateSnapping before UpdateTargetSpaceTransform We are moving target space transforms from transform tree to property tree cached data and are going to compute the transforms on demand. As a result, instead of applying scroll snapping to target space transforms after we compute each transforms, we can apply it to node's to_parent transforms before computing. This CL should not have any effect on behavior and performance. BUG=624120 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== cc: transform tree UpdateSnapping before UpdateTargetSpaceTransform We are moving target space transforms from transform tree to property tree cached data and are going to compute the transforms on demand. As a result, instead of applying scroll snapping to target space transforms after we compute each transforms, we can apply it to node's to_parent transforms before computing. This CL should not have any effect on behavior and performance. BUG=624120 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: transform tree UpdateSnapping before UpdateTargetSpaceTransform We are moving target space transforms from transform tree to property tree cached data and are going to compute the transforms on demand. As a result, instead of applying scroll snapping to target space transforms after we compute each transforms, we can apply it to node's to_parent transforms before computing. This CL should not have any effect on behavior and performance. BUG=624120 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
sunxd@chromium.org changed reviewers: + ajuma@chromium.org, jaydasika@chromium.org, vollick@chromium.org, weiliangc@chromium.org
The CQ bit was checked by ajuma@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by sunxd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== cc: transform tree UpdateSnapping before UpdateTargetSpaceTransform We are moving target space transforms from transform tree to property tree cached data and are going to compute the transforms on demand. As a result, instead of applying scroll snapping to target space transforms after we compute each transforms, we can apply it to node's to_parent transforms before computing. This CL should not have any effect on behavior and performance. BUG=624120 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: transform tree UpdateSnapping before UpdateTargetSpaceTransform We are moving target space transforms from transform tree to property tree cached data and are going to compute the transforms on demand. As a result, instead of applying scroll snapping to target space transforms after we compute each transforms, we can apply it to node's to_parent transforms before computing. This CL should not have any effect on behavior and performance. BUG=624120 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== cc: transform tree UpdateSnapping before UpdateTargetSpaceTransform We are moving target space transforms from transform tree to property tree cached data and are going to compute the transforms on demand. As a result, instead of applying scroll snapping to target space transforms after we compute each transforms, we can apply it to node's to_parent transforms before computing. This CL should not have any effect on behavior and performance. BUG=624120 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: transform tree UpdateSnapping before UpdateTargetSpaceTransform We are moving target space transforms from transform tree to property tree cached data and are going to compute the transforms on demand. As a result, instead of applying scroll snapping to target space transforms after we compute each transforms, we can apply it to node's to_parent transforms before computing. This CL should not have any effect on behavior and performance. BUG=624120 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/6328bc770c974f2a5e097108bd968dff1b70205e Cr-Commit-Position: refs/heads/master@{#404186} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6328bc770c974f2a5e097108bd968dff1b70205e Cr-Commit-Position: refs/heads/master@{#404186} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
