Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Unified Diff: src/builtins.cc

Issue 2122183002: [Interpreter] Collect type feedback for calls in the bytecode handler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updated cctest.status to mark the tests fail with ignition. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.h ('k') | src/code-factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index 02a700574578e08a0deca80bdbddc6ea544be78e..11eac8e2c4189b5979d50060e1983d34426fa70b 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -5871,12 +5871,21 @@ Handle<Code> Builtins::CallBoundFunction(TailCallMode tail_call_mode) {
return Handle<Code>::null();
}
-Handle<Code> Builtins::InterpreterPushArgsAndCall(TailCallMode tail_call_mode) {
+Handle<Code> Builtins::InterpreterPushArgsAndCall(TailCallMode tail_call_mode,
+ CallableType function_type) {
switch (tail_call_mode) {
case TailCallMode::kDisallow:
- return InterpreterPushArgsAndCall();
+ if (function_type == CallableType::kJSFunction) {
+ return InterpreterPushArgsAndCallFunction();
+ } else {
+ return InterpreterPushArgsAndCall();
+ }
case TailCallMode::kAllow:
- return InterpreterPushArgsAndTailCall();
+ if (function_type == CallableType::kJSFunction) {
+ return InterpreterPushArgsAndTailCallFunction();
+ } else {
+ return InterpreterPushArgsAndTailCall();
+ }
}
UNREACHABLE();
return Handle<Code>::null();
« no previous file with comments | « src/builtins.h ('k') | src/code-factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698