[Interpreter] Collect type feedback for calls in the bytecode handler

src/interpreter/bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecode-generator.h"
 
 #include "src/ast/scopes.h"
 #include "src/code-stubs.h"
 #include "src/compiler.h"
 #include "src/interpreter/bytecode-register-allocator.h"
@@ skipping 2504 matching lines @@
         .LoadLiteral(Smi::FromInt(expr->position()))
         .StoreAccumulatorInRegister(eval_position);
 
     // Call ResolvePossiblyDirectEval and modify the callee.
     builder()
         ->CallRuntime(Runtime::kResolvePossiblyDirectEval, callee_for_eval, 6)
         .StoreAccumulatorInRegister(callee);
   }
 
   builder()->SetExpressionPosition(expr);
-  builder()->Call(callee, receiver, 1 + args->length(),
-                  feedback_index(expr->CallFeedbackICSlot()),
-                  expr->tail_call_mode());
+  if (expr->CallFeedbackICSlot().IsInvalid()) {
+    builder()->Call(callee, receiver, 1 + args->length(),
+                    expr->tail_call_mode());
+  } else {
+    DCHECK(call_type != Call::POSSIBLY_EVAL_CALL);

[Benedikt Meurer, 2016/07/09 18:19:22]

Nit: Use DCHECK_NE.

[mythria, 2016/07/11 15:25:24]

This code changed a little and I moved DCHECK to the if part. Done.

+    builder()->CallWithFeedback(callee, receiver, 1 + args->length(),
+                                feedback_index(expr->CallFeedbackICSlot()),
+                                expr->tail_call_mode());
+  }
   execution_result()->SetResultInAccumulator();
 }
 
 void BytecodeGenerator::VisitCallSuper(Call* expr) {
   RegisterAllocationScope register_scope(this);
   SuperCallReference* super = expr->expression()->AsSuperCallReference();
 
   // Prepare the constructor to the super call.
   Register this_function = register_allocator()->NewRegister();
   VisitForAccumulatorValue(super->this_function_var());
@@ skipping 629 matching lines @@
   return execution_context()->scope()->language_mode();
 }
 
 int BytecodeGenerator::feedback_index(FeedbackVectorSlot slot) const {
   return TypeFeedbackVector::GetIndex(slot);
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8