Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2122173003: [runtime] Specifically handle robust RUNTIME_ASSERTs. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Specifically handle robust RUNTIME_ASSERTs. This changes the last few remaining RUNTIME_ASSERT calls that need to be intentionally robust because fuzzers or other callers can invoke the runtime functions in question with unsafe arguments. R=yangguo@chromium.org BUG=v8:5066 Committed: https://crrev.com/8acc97e2e1773b06a29790df3869fc24a59b23dd Cr-Commit-Position: refs/heads/master@{#37576}

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -22 lines) Patch
M src/runtime/runtime-i18n.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 6 chunks +27 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-06 15:51:42 UTC) #3
Yang
On 2016/07/06 15:51:42, Michael Starzinger wrote: lgtm.
4 years, 5 months ago (2016-07-07 09:23:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122173003/20001
4 years, 5 months ago (2016-07-07 09:36:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 09:38:25 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 09:40:57 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8acc97e2e1773b06a29790df3869fc24a59b23dd
Cr-Commit-Position: refs/heads/master@{#37576}

Powered by Google App Engine
This is Rietveld 408576698