Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2122153002: Restructure and add logs to WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID (Closed)

Created:
4 years, 5 months ago by perkj_chrome
Modified:
4 years, 5 months ago
Reviewers:
Guido Urdaneta
CC:
chromium-reviews, jam, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restructure and add logs to WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID BUG=625024, 622085 Committed: https://crrev.com/5225533743d7b722480e20fe5e2627fd04893dea Cr-Commit-Position: refs/heads/master@{#403903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/media/webrtc/webrtc_getusermedia_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/media/getusermedia.html View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/media/webrtc_test_utilities.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
perkj_chrome
please?
4 years, 5 months ago (2016-07-06 13:10:04 UTC) #2
Guido Urdaneta
On 2016/07/06 13:10:04, perkj_chrome wrote: > please? lgtm
4 years, 5 months ago (2016-07-06 14:13:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122153002/1
4 years, 5 months ago (2016-07-06 14:15:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 14:22:55 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 14:22:58 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 14:25:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5225533743d7b722480e20fe5e2627fd04893dea
Cr-Commit-Position: refs/heads/master@{#403903}

Powered by Google App Engine
This is Rietveld 408576698