[MediaNotification] Use common idiom to detect if OS version is "N"

[MediaNotification] Use common idiom to detect if OS version is "N"

BUG=625936
Committed: https://crrev.com/180530e41d516635c315aaea0e02a658469a3126
Cr-Commit-Position: refs/heads/master@{#403899}

[Zhiqiang Zhang (Slow), 2016-07-06 11:03:38]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2016-07-06 11:19:32]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 11:19:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 12:01:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 12:01:58]

Dry run: This issue passed the CQ dry run.

[whywhat, 2016-07-06 12:39:53]

avayvod@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2016-07-06 12:39:53]

lgtm

https://codereview.chromium.org/2122143002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
(right):

https://codereview.chromium.org/2122143002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:752:
if (Build.VERSION.CODENAME.equals("N") || Build.VERSION.SDK_INT >
Build.VERSION_CODES.M) {
nit: couldn't you just do

return Build.VERSION.CODENAME.equals("N") || Build.VERSION.SDK_INT >
Build.VERSION_CODES.M ?

It's sad we don't have something like this in some org.chromium.base.BuildInfo
or ApiCompatibilityUtils although we try to avoid build version specific code by
using the latter. Just a thought :)

[Zhiqiang Zhang (Slow), 2016-07-06 13:09:02]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-07-06 13:09:02]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/2122143002/#ps20001
(title: "addressed nits")

[commit-bot: I haz the power, 2016-07-06 13:09:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 13:47:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-06 13:47:35]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-06 13:49:19]

Description was changed from

==========
[MediaNotification] Use common idiom to detect if OS version is "N"

BUG=625936
==========

to

==========
[MediaNotification] Use common idiom to detect if OS version is "N"

BUG=625936

Committed: https://crrev.com/180530e41d516635c315aaea0e02a658469a3126
Cr-Commit-Position: refs/heads/master@{#403899}
==========

[commit-bot: I haz the power, 2016-07-06 13:49:20]

Patchset 2 (id:??) landed as
https://crrev.com/180530e41d516635c315aaea0e02a658469a3126
Cr-Commit-Position: refs/heads/master@{#403899}

[mlamouri (slow - plz ping), 2016-07-06 13:52:52]

lgtm