Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 212213004: Make mark-merge-base cap the marked merge base at the real merge-base. (Closed)

Created:
6 years, 9 months ago by iannucci
Modified:
6 years, 9 months ago
Reviewers:
agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Make mark-merge-base cap the marked merge base at the real merge-base. R=agable@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=259697

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M git_common.py View 1 2 chunks +22 lines, -5 lines 0 comments Download
M tests/git_common_test.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
iannucci
6 years, 9 months ago (2014-03-26 09:01:36 UTC) #1
agable
LGTM % nits. https://codereview.chromium.org/212213004/diff/1/git_common.py File git_common.py (right): https://codereview.chromium.org/212213004/diff/1/git_common.py#newcode248 git_common.py:248: def check(*cmd, **kwargs): Again with your ...
6 years, 9 months ago (2014-03-26 21:00:09 UTC) #2
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 9 months ago (2014-03-26 21:26:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/212213004/40001
6 years, 9 months ago (2014-03-26 21:26:11 UTC) #4
iannucci
https://chromiumcodereview.appspot.com/212213004/diff/1/git_common.py File git_common.py (right): https://chromiumcodereview.appspot.com/212213004/diff/1/git_common.py#newcode248 git_common.py:248: def check(*cmd, **kwargs): On 2014/03/26 21:00:09, agable wrote: > ...
6 years, 9 months ago (2014-03-26 21:26:38 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 21:27:48 UTC) #6
Message was sent while issue was closed.
Change committed as 259697

Powered by Google App Engine
This is Rietveld 408576698