Issue 2122123002: Add a test for a multipart image as cache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2122123002: Add a test for a multipart image as cache (Closed)

Created:
4 years, 5 months ago by hajimehoshi

Modified:
4 years, 5 months ago

Reviewers:
hiroshige, Mike West

CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add a test for a multipart image as cache This CL adds a test to check the case when a multipart image is retrieved from cache. The test just follows the current behavior. BUG=n/a

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 739793003 Patch 60001

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hajimehoshi

4 years, 5 months ago (2016-07-06 09:11:45 UTC) #3

On 2016/07/06 08:49:27, hajimehoshi wrote:
> PTAL

Oops, I should've used memoryCache(), and even if I did it, the same
ImageResource instance would be tested and that doesn't make sense. Let me close
this. Sorry for confusion.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages