Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/OverlayController.js

Issue 2122113004: [DevTools] Support for the inspector target type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/main/OverlayController.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js b/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js
index 81300a13b0582df5ea5fec1ae673ae657e56023e..ef12a1349df17240426448c1bb2e1b0c8af81631 100644
--- a/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js
+++ b/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js
@@ -7,21 +7,35 @@
*/
WebInspector.OverlayController = function()
{
- WebInspector.moduleSetting("disablePausedStateOverlay").addChangeListener(this._updateOverlayMessage, this);
+ WebInspector.moduleSetting("disablePausedStateOverlay").addChangeListener(this._updateAllOverlayMessages, this);
WebInspector.targetManager.addModelListener(WebInspector.DebuggerModel, WebInspector.DebuggerModel.Events.DebuggerPaused, this._updateOverlayMessage, this);
WebInspector.targetManager.addModelListener(WebInspector.DebuggerModel, WebInspector.DebuggerModel.Events.DebuggerResumed, this._updateOverlayMessage, this);
WebInspector.targetManager.addModelListener(WebInspector.DebuggerModel, WebInspector.DebuggerModel.Events.GlobalObjectCleared, this._updateOverlayMessage, this);
}
WebInspector.OverlayController.prototype = {
+ _updateAllOverlayMessages: function()
+ {
+ for (var target of WebInspector.targetManager.targets())
+ this._updateTargetOverlayMessage(WebInspector.DebuggerModel.fromTarget(target));
+ },
/**
* @param {!WebInspector.Event} event
*/
_updateOverlayMessage: function(event)
{
- var debuggerModel = /** @type {!WebInspector.DebuggerModel} */ (event.target);
+ this._updateTargetOverlayMessage(/** @type {!WebInspector.DebuggerModel} */ (event.target));
+ },
+
+ /**
+ * @param {?WebInspector.DebuggerModel} debuggerModel
+ */
+ _updateTargetOverlayMessage: function(debuggerModel)
+ {
+ if (!debuggerModel || debuggerModel.target().isJSInspector())
+ return;
var message = debuggerModel.isPaused() && !WebInspector.moduleSetting("disablePausedStateOverlay").get() ? WebInspector.UIString("Paused in debugger") : undefined;
debuggerModel.target().pageAgent().setOverlayMessage(message);
- }
+ },
}

Powered by Google App Engine
This is Rietveld 408576698