Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2122113004: [DevTools] Support for the inspector target type (Closed)

Created:
4 years, 5 months ago by eostroukhov-old
Modified:
4 years, 5 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support for the inspector target type No longer try to set overlay message and no longer send "Inspecotr.enable" message to the targets of JS inspector type. BUG=624494 Committed: https://crrev.com/becc4e65e5d4497a460323ccf9afbfde3a816dee Cr-Commit-Position: refs/heads/master@{#405601}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/OverlayController.js View 1 1 chunk +16 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
eostroukhov-old
4 years, 5 months ago (2016-07-07 17:18:43 UTC) #2
dgozman
lgtm
4 years, 5 months ago (2016-07-07 17:58:16 UTC) #3
pfeldman
https://codereview.chromium.org/2122113004/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js File third_party/WebKit/Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/2122113004/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js#newcode328 third_party/WebKit/Source/devtools/front_end/main/Main.js:328: if (!this._mainTarget.isJSInspector()) Lets steer it closer to capabilities. I.e. ...
4 years, 5 months ago (2016-07-07 18:00:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122113004/20001
4 years, 5 months ago (2016-07-13 23:30:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/255474)
4 years, 5 months ago (2016-07-14 01:54:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122113004/20001
4 years, 5 months ago (2016-07-14 21:07:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 22:17:51 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 22:18:08 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 22:19:53 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/becc4e65e5d4497a460323ccf9afbfde3a816dee
Cr-Commit-Position: refs/heads/master@{#405601}

Powered by Google App Engine
This is Rietveld 408576698