Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2122083002: Move CSS3 Paged Media interface into WebLocalFrame. (Closed)

Created:
4 years, 5 months ago by dcheng
Modified:
4 years, 5 months ago
Reviewers:
tkent, Lei Zhang
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dcheng, dglazkov+blink, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-blink_chromium.org, robhogan (do not use), site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CSS3 Paged Media interface into WebLocalFrame. BUG=416660 Committed: https://crrev.com/676a479607fd978f51b0e2a9bffd7d8896ca9a97 Cr-Commit-Position: refs/heads/master@{#404010}

Patch Set 1 #

Patch Set 2 : More build fixes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -79 lines) Patch
M components/printing/renderer/print_web_view_helper.h View 1 5 chunks +6 lines, -5 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/renderer/print_web_view_helper_mac.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_pdf_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/test_runner_for_specific_view.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 1 chunk +24 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (4 generated)
dcheng
I noticed https://codereview.chromium.org/2116283002/ fly by: it's easy enough to wholly move this one into WebLocalFrame ...
4 years, 5 months ago (2016-07-06 03:50:13 UTC) #2
Lei Zhang
chrome/ lgtm https://codereview.chromium.org/2122083002/diff/20001/third_party/WebKit/public/web/WebLocalFrame.h File third_party/WebKit/public/web/WebLocalFrame.h (right): https://codereview.chromium.org/2122083002/diff/20001/third_party/WebKit/public/web/WebLocalFrame.h#newcode152 third_party/WebKit/public/web/WebLocalFrame.h:152: extra blank line?
4 years, 5 months ago (2016-07-06 17:59:17 UTC) #3
dcheng
https://codereview.chromium.org/2122083002/diff/20001/third_party/WebKit/public/web/WebLocalFrame.h File third_party/WebKit/public/web/WebLocalFrame.h (right): https://codereview.chromium.org/2122083002/diff/20001/third_party/WebKit/public/web/WebLocalFrame.h#newcode152 third_party/WebKit/public/web/WebLocalFrame.h:152: On 2016/07/06 17:59:16, Lei Zhang wrote: > extra blank ...
4 years, 5 months ago (2016-07-06 21:41:06 UTC) #4
dcheng
+tkent for components/test_runner and Blink
4 years, 5 months ago (2016-07-06 21:41:48 UTC) #6
tkent
lgtm
4 years, 5 months ago (2016-07-06 23:05:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122083002/20001
4 years, 5 months ago (2016-07-07 00:22:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 00:29:15 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 00:31:06 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/676a479607fd978f51b0e2a9bffd7d8896ca9a97
Cr-Commit-Position: refs/heads/master@{#404010}

Powered by Google App Engine
This is Rietveld 408576698