Display extension name on device chooser title

chrome/browser/chooser_controller/chooser_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chooser_controller/chooser_controller.h"
 
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/grit/generated_resources.h"
+#include "components/url_formatter/elide_url.h"
 #include "content/public/browser/render_frame_host.h"
+#include "content/public/browser/web_contents.h"
+#include "extensions/browser/extension_registry.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "url/gurl.h"
 #include "url/origin.h"
 
 ChooserController::ChooserController(content::RenderFrameHost* owner)
     : owning_frame_(owner) {}
 
 ChooserController::~ChooserController() {}
 
-url::Origin ChooserController::GetOrigin() const {
-  return owning_frame_ ? owning_frame_->GetLastCommittedOrigin()
-                       : url::Origin();
+base::string16 ChooserController::GetTitle() const {
+  return l10n_util::GetStringFUTF16(IDS_DEVICE_CHOOSER_PROMPT,
+                                    GetTitlePrefix());
 }
+
+base::string16 ChooserController::GetTitlePrefix() const {
+  if (!owning_frame_)
+    return base::string16();
+
+  base::string16 title_prefix;
+  url::Origin last_committed_origin = owning_frame_->GetLastCommittedOrigin();
+  content::WebContents* web_contents =
+      content::WebContents::FromRenderFrameHost(owning_frame_);
+  content::BrowserContext* browser_context = web_contents->GetBrowserContext();
+  extensions::ExtensionRegistry* extension_registry =
+      extensions::ExtensionRegistry::Get(browser_context);
+  if (extension_registry) {
+    const extensions::Extension* extension =
+        extension_registry->enabled_extensions().GetExtensionOrAppByURL(
+            GURL(last_committed_origin.Serialize()));
+    if (extension)
+      title_prefix = base::UTF8ToUTF16(extension->name());
+  }
+
+  if (title_prefix.empty()) {

[Reilly Grant (use Gerrit), 2016/07/11 21:48:03]

We can determine if this is an extension URL or not by checking if the scheme is
chrome-extension:// instead of always looking up the URL in the extension
registry. This keeps the two paths more separate.

[juncai, 2016/07/11 23:16:44]

Done.

+    title_prefix = url_formatter::FormatOriginForSecurityDisplay(
+        last_committed_origin,
+        url_formatter::SchemeDisplay::OMIT_CRYPTOGRAPHIC);
+  } else {
+    // Add quote if the it is a Chrome app/extension name.

[Reilly Grant (use Gerrit), 2016/07/11 21:48:02]

Quotation marks need to be localized. Instead of re-using the string create one
string for an origin and one for an app name.

[juncai, 2016/07/11 23:16:44]

Done.

+    title_prefix.insert(title_prefix.begin(), '"');
+    title_prefix.insert(title_prefix.end(), '"');
+  }
+
+  return title_prefix;
+}