Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2122063003: Search in apks/ as well as *_apk/ for built apks. (Closed)

Created:
4 years, 5 months ago by ghost stip (do not use)
Modified:
4 years, 5 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
ghost stip (do not use)
I once met an Icelandic man at a cafe in Reykjavík. After asking my friends ...
4 years, 5 months ago (2016-07-06 06:40:50 UTC) #2
jbudorick
On 2016/07/06 06:40:50, stip wrote: > I once met an Icelandic man at a cafe ...
4 years, 5 months ago (2016-07-06 14:47:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2122063003/1
4 years, 5 months ago (2016-07-06 15:12:42 UTC) #5
ghost stip (do not use)
See linked bug. remote_device_dummy.apk is the only thing preventing dedup for many targets.
4 years, 5 months ago (2016-07-06 15:14:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/cf1ef26b8334f62563e36511c643d1836767e137
4 years, 5 months ago (2016-07-06 15:16:03 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 15:16:05 UTC) #9
jbudorick
On 2016/07/06 15:14:34, stip wrote: > See linked bug. remote_device_dummy.apk is the only thing preventing ...
4 years, 5 months ago (2016-07-06 15:38:19 UTC) #10
ghost stip (do not use)
4 years, 5 months ago (2016-07-06 21:53:55 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2122233003/ by stip@chromium.org.

The reason for reverting is: Speculative revert to see if this fixes
https://bugs.chromium.org/p/chromium/issues/detail?id=626042..

Powered by Google App Engine
This is Rietveld 408576698