Shift+F10 should open Context Menu regardless the state of NumLock/CapsLock

third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index 063029b1238e07c7c351984fd35326c5874baa40..1ce4ec7dbcc0a353c875517c92e24a2012f430cf 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -838,7 +838,7 @@ WebInputEventResult WebFrameWidgetImpl::handleKeyEvent(const WebKeyboardEvent& e
 #endif
 
     bool isUnmodifiedMenuKey = !(event.modifiers & WebInputEvent::InputModifiers) && event.windowsKeyCode == VKEY_APPS;

[chongz, 2016/07/06 18:30:34]

Ya actually it's doing the same thing as this line, the original author seems
forgot ShiftF10...

See:
https://chromium.googlesource.com/chromium/src/+/0bbd1cc7fdf21066699f1c5fd870...

-    bool isShiftF10 = event.modifiers == WebInputEvent::ShiftKey && event.windowsKeyCode == VKEY_F10;
+    bool isShiftF10 = (event.modifiers & WebInputEvent::InputModifiers) == WebInputEvent::ShiftKey && event.windowsKeyCode == VKEY_F10;

[bokan, 2016/07/06 18:21:11]

Actually, before you submit, how does this work? If Shift + NumLock are down:
event.modifiers & InputModifiers == ShiftKey & NumLock != ShiftKey so isShiftF10
will be false.

Should this instead be: (event.modifiers & ShiftKey) && !(event.modifiers &
~InputModifiers)? i.e. The shift key is set and no modifiers outside
InputModifiers are set. Or am I misunderstanding something?

[bokan, 2016/07/06 18:23:30]

nvm...just realized Num/Caps lock aren't in InputModifiers. carry on...

     if ((isUnmodifiedMenuKey || isShiftF10) && event.type == contextMenuTriggeringEventType) {
         view()->sendContextMenuEvent(event);
         return WebInputEventResult::HandledSystem;