Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2122023002: Cross-process frames should be notified of device scale factor changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Version of patch without second test. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 7054fdd723b88ac59945293a8c1ba38d4bd9da4d..0d0b82e256f691e0d5bd4a5127cfd5cb76568a42 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -591,6 +591,9 @@ bool RenderWidgetHostImpl::GetResizeParams(ResizeParams* resize_params) {
if (view_) {
resize_params->new_size = view_->GetRequestedRendererSize();
+ // TODO(wjmaclean): Can we just get rid of physical_backing_size and just
+ // deal with it on the renderer side? It seems to always be
+ // ScaleToCeiledSize(new_size, device_scale_factor) ??
resize_params->physical_backing_size = view_->GetPhysicalBackingSize();
resize_params->top_controls_height = view_->GetTopControlsHeight();
resize_params->top_controls_shrink_blink_size =
@@ -1224,10 +1227,11 @@ void RenderWidgetHostImpl::RemoveInputEventObserver(
void RenderWidgetHostImpl::GetWebScreenInfo(blink::WebScreenInfo* result) {
TRACE_EVENT0("renderer_host", "RenderWidgetHostImpl::GetWebScreenInfo");
- if (view_)
- view_->GetScreenInfo(result);
+ if (delegate_)
+ delegate_->GetScreenInfo(result);
else
- RenderWidgetHostViewBase::GetDefaultScreenInfo(result);
+ NOTREACHED();
+
// TODO(sievers): find a way to make this done another way so the method
// can be const.
latency_tracker_.set_device_scale_factor(result->deviceScaleFactor);

Powered by Google App Engine
This is Rietveld 408576698