content/browser/devtools/protocol/page_handler.cc - Issue 2122023002: Cross-process frames should be notified of device scale factor changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/page_handler.cc

Issue 2122023002: Cross-process frames should be notified of device scale factor changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Version of patch without second test. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/color_picker.cc ('k') | content/browser/frame_host/cross_process_frame_connector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/page_handler.cc

diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc

index 0e8d29b29b151d82ad24d0cc680fddd03b4c485e..1ee852255f3f8978a0e36d44a8b4725c0242c6a5 100644

--- a/content/browser/devtools/protocol/page_handler.cc

+++ b/content/browser/devtools/protocol/page_handler.cc

@@ -19,6 +19,7 @@

#include "content/browser/renderer_host/render_widget_host_impl.h"

#include "content/browser/renderer_host/render_widget_host_view_base.h"

#include "content/browser/web_contents/web_contents_impl.h"

+#include "content/browser/web_contents/web_contents_view.h"

#include "content/common/view_messages.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/javascript_dialog_manager.h"

@@ -471,7 +472,7 @@ void PageHandler::InnerSwapCompositorFrame() {

1 / metadata.device_scale_factor);

blink::WebScreenInfo screen_info;

- view->GetScreenInfo(&screen_info);

+ GetWebContents()->GetView()->GetScreenInfo(&screen_info);

double device_scale_factor = screen_info.deviceScaleFactor;

double scale = 1;

« no previous file with comments | « content/browser/devtools/protocol/color_picker.cc ('k') | content/browser/frame_host/cross_process_frame_connector.h » ('j') | no next file with comments »