Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2122023002: Cross-process frames should be notified of device scale factor changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 8c8bae4d2a923c28f62218a6a14ad6ca02fd40e5..280123ea75839293f9958ec6a662d91a58dd565d 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -588,6 +588,9 @@ bool RenderWidgetHostImpl::GetResizeParams(ResizeParams* resize_params) {
if (view_) {
resize_params->new_size = view_->GetRequestedRendererSize();
+ // TODO(wjmaclean): Can we just get rid of physical_backing_size and just
+ // deal with it on the renderer side? It seems to always be
+ // ScaleToCeiledSize(new_size, device_scale_factor) ??
oshima 2016/07/07 22:45:43 Ideally we should just send the backing size (or p
wjmaclean 2016/07/08 17:38:33 Ok ... so we would send the dsf and physical_backi
resize_params->physical_backing_size = view_->GetPhysicalBackingSize();
resize_params->top_controls_height = view_->GetTopControlsHeight();
resize_params->top_controls_shrink_blink_size =
@@ -1214,10 +1217,13 @@ void RenderWidgetHostImpl::RemoveInputEventObserver(
void RenderWidgetHostImpl::GetWebScreenInfo(blink::WebScreenInfo* result) {
TRACE_EVENT0("renderer_host", "RenderWidgetHostImpl::GetWebScreenInfo");
- if (view_)
+ if (view_) {
view_->GetScreenInfo(result);
- else
+ } else {
RenderWidgetHostViewBase::GetDefaultScreenInfo(result);
+ // The delegate may have more up-to-date information if we're a sub-frame.
+ result->deviceScaleFactor = delegate_->DefaultDeviceScaleFactor();
+ }
// TODO(sievers): find a way to make this done another way so the method
// can be const.
latency_tracker_.set_device_scale_factor(result->deviceScaleFactor);

Powered by Google App Engine
This is Rietveld 408576698