Make ReplaceSelectionCommand to handle empty SPAN replacement

Make ReplaceSelectionCommand to handle empty SPAN replacement

This patch makes |ReplaceSelectionCommand| to handle empty SPAN replacement.

Before this patch, it crashes at |SimplifyMarkupCommand::doApply()| with
null pointer reference passed by |ReplaceSelectionCommand| with
null |insertNodes.firstNodeInserted()|.

BUG=619131
TEST=run_webkit_unit_tests --gtest_filter=ReplaceSelectionCommandTest.pastingEmptySpan

Committed: https://crrev.com/cd80804c61b6d9578a633d3546043d03aecdf27b
Cr-Commit-Position: refs/heads/master@{#404075}

[yosin_UTC9, 2016-07-06 06:53:50]

Description was changed from

==========
2016-07-06T14:51:16

BUG=
==========

to

==========
Make ReplaceSelectionCommand to handle empty SPAN replacement

This patch makes |ReplaceSelectionCommand| to handle empty SPAN replacement.

Before this patch, it crashes at |SimplifyMarkupCommand::doApply()| with
null pointer reference passed by |ReplaceSelectionCommand| with
null |insertNodes.firstNodeInserted()|.

BUG=619131
TEST=run_webkit_unit_tests --gtest_filter=ReplaceSelectionCommandTest.EmptySpan
==========

[yosin_UTC9, 2016-07-07 01:56:24]

Description was changed from

==========
Make ReplaceSelectionCommand to handle empty SPAN replacement

This patch makes |ReplaceSelectionCommand| to handle empty SPAN replacement.

Before this patch, it crashes at |SimplifyMarkupCommand::doApply()| with
null pointer reference passed by |ReplaceSelectionCommand| with
null |insertNodes.firstNodeInserted()|.

BUG=619131
TEST=run_webkit_unit_tests --gtest_filter=ReplaceSelectionCommandTest.EmptySpan
==========

to

==========
Make ReplaceSelectionCommand to handle empty SPAN replacement

This patch makes |ReplaceSelectionCommand| to handle empty SPAN replacement.

Before this patch, it crashes at |SimplifyMarkupCommand::doApply()| with
null pointer reference passed by |ReplaceSelectionCommand| with
null |insertNodes.firstNodeInserted()|.

BUG=619131
TEST=run_webkit_unit_tests
--gtest_filter=ReplaceSelectionCommandTest.pastingEmptySpan
==========

[yosin_UTC9, 2016-07-07 02:28:25]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-07-07 02:28:26]

PTAL

[Xiaocheng, 2016-07-07 02:49:06]

lgtm

[yosin_UTC9, 2016-07-07 03:29:35]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-07-07 03:29:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 04:42:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-07 04:42:13]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 04:44:05]

Description was changed from

==========
Make ReplaceSelectionCommand to handle empty SPAN replacement

This patch makes |ReplaceSelectionCommand| to handle empty SPAN replacement.

Before this patch, it crashes at |SimplifyMarkupCommand::doApply()| with
null pointer reference passed by |ReplaceSelectionCommand| with
null |insertNodes.firstNodeInserted()|.

BUG=619131
TEST=run_webkit_unit_tests
--gtest_filter=ReplaceSelectionCommandTest.pastingEmptySpan
==========

to

==========
Make ReplaceSelectionCommand to handle empty SPAN replacement

This patch makes |ReplaceSelectionCommand| to handle empty SPAN replacement.

Before this patch, it crashes at |SimplifyMarkupCommand::doApply()| with
null pointer reference passed by |ReplaceSelectionCommand| with
null |insertNodes.firstNodeInserted()|.

BUG=619131
TEST=run_webkit_unit_tests
--gtest_filter=ReplaceSelectionCommandTest.pastingEmptySpan

Committed: https://crrev.com/cd80804c61b6d9578a633d3546043d03aecdf27b
Cr-Commit-Position: refs/heads/master@{#404075}
==========

[commit-bot: I haz the power, 2016-07-07 04:44:06]

Patchset 2 (id:??) landed as
https://crrev.com/cd80804c61b6d9578a633d3546043d03aecdf27b
Cr-Commit-Position: refs/heads/master@{#404075}