Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2121973003: Replace/remove some uses of DeviceDisplayInfo (Closed)

Created:
4 years, 5 months ago by gsennton
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace/remove some uses of DeviceDisplayInfo This is part of an effort to remove the Android-specific DeviceDisplayInfo that can currently only handle one Display. To support attaching WebView to a Presentation we need a solution that allows for multiple displays. BUG=625089 Committed: https://crrev.com/32db3cb3ef603f3510ca843ffc57e80f558f53d1 Cr-Commit-Position: refs/heads/master@{#404353}

Patch Set 1 #

Patch Set 2 : Fix compilation for Chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/browser/android/tab_android.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (8 generated)
gsennton
bauerb@ for tab_android.cc sievers@chromium.org: for content/browser wuhuu tiny changes! :D
4 years, 5 months ago (2016-07-05 11:08:54 UTC) #2
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-05 11:12:40 UTC) #3
no sievers
lgtm
4 years, 5 months ago (2016-07-06 20:03:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121973003/1
4 years, 5 months ago (2016-07-07 11:44:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/92486)
4 years, 5 months ago (2016-07-07 12:01:54 UTC) #8
gsennton
On 2016/07/07 12:01:54, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 5 months ago (2016-07-07 12:42:58 UTC) #9
gsennton
On 2016/07/07 12:42:58, gsennton wrote: > On 2016/07/07 12:01:54, commit-bot: I haz the power wrote: ...
4 years, 5 months ago (2016-07-07 18:07:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121973003/20001
4 years, 5 months ago (2016-07-07 18:09:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/258719)
4 years, 5 months ago (2016-07-07 19:42:04 UTC) #15
gsennton
On 2016/07/07 19:42:04, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 5 months ago (2016-07-08 11:16:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121973003/20001
4 years, 5 months ago (2016-07-08 11:17:35 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 14:08:24 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 14:08:33 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:10:44 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32db3cb3ef603f3510ca843ffc57e80f558f53d1
Cr-Commit-Position: refs/heads/master@{#404353}

Powered by Google App Engine
This is Rietveld 408576698