third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h - Issue 2121973002: Fallback to 300x150 instead of 0x0 size for SVG inside content()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h

Issue 2121973002: Fallback to 300x150 instead of 0x0 size for SVG inside content() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/misc/svg-image-in-content-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h b/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h

index 8f4da9b40c5d57b6cac3b611df58c597935be7bd..9f9a04aadada4b0a3703bcdcef5ce326b007896a 100644

--- a/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h

+++ b/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h

@@ -50,13 +50,7 @@ public:

bool errorOccurred() const override { return m_styleImage->errorOccurred(); }

bool imageHasRelativeSize() const override { return m_styleImage->imageHasRelativeSize(); }

- LayoutSize imageSize(float multiplier) const override

- {

- // TODO(davve): Find out the default object size, if any, in this context.

- return m_styleImage->imageSize(*m_layoutObject, multiplier, LayoutSize());

- }

+ LayoutSize imageSize(float multiplier) const override;

WrappedImagePtr imagePtr() const override { return m_styleImage->data(); }

DECLARE_VIRTUAL_TRACE();